Re: [PATCH] memcg: correct return value at mem_cgroup reclaim

[Balbir Singh <balbir@linux.vnet.ibm.com>]

* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-12-09 09:28:42]:

> On Sun, 6 Dec 2009 22:30:46 +0900
> Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp> wrote:
> 
> > hi,
> > 
> > On Sun, 6 Dec 2009 18:16:14 +0800
> > Liu bo <bo-liu@hotmail.com> wrote:
> > 
> > > 
> > > In order to indicate reclaim has succeeded, mem_cgroup_hierarchical_reclaim() used to return 1.
> > > Now the return value is without indicating whether reclaim has successded usage, so just return the total reclaimed pages don't plus 1.
> > >  
> > > Signed-off-by: Liu Bo <bo-liu@hotmail.com>
> > > ---
> > >  
> > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > > index 14593f5..51b6b3c 100644
> > > --- a/mm/memcontrol.c
> > > +++ b/mm/memcontrol.c
> > > @@ -737,7 +737,7 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem,
> > >    css_put(&victim->css);
> > >    total += ret;
> > >    if (mem_cgroup_check_under_limit(root_mem))
> > > -   return 1 + total;
> > > +   return total;
> > >   }
> > >   return total;
> > >  } 		 	   		  
> > What's the benefit of this change ?
> > I can't find any benefit to bother changing current behavior.
> > 
> 
> please leave this as it is or adds comment.
> This "1 + total" means "returning success, not 0" even if this has no behavior changes.
>

I prefer adding the comments, I will get to it if Liu does not.

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>