Re: [PATCH 0/2] mm hugetlb x86: add hugepage support to pagemap

[Andrew Morton <akpm@linux-foundation.org>]

On Mon, 07 Dec 2009 16:59:18 +0900
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:

> Most callers of pmd_none_or_clear_bad() check whether the target
> page is in a hugepage or not, but mincore() and walk_page_range() do
> not check it. So if we read /proc/pid/pagemap for the hugepage
> on x86 machine, the hugepage memory is leaked as shown below.
> This patch fixes it by extending pagemap interface to support hugepages.
> 
> I split this fix into two patches.  The first patch just adds the check
> for hugepages, and the second patch adds a new member to struct mm_walk
> to handle the hugepages.

I kind of dislike the practice of putting all the changelog in patch
[0/n] and then leaving the patches themselves practically
unchangelogged.  Because

a) Someone (ie: me) needs to go and shuffle all the text around so
   that the information gets itself into the git record.  We don't add
   changelog-only commits to git!

b) Someone (ie: me) might decide to backport a subset of the patches
   into -stable.  Now someone (ie: me) needs to carve up the changelogs
   so that the pieces which go into -stable still make standalone sense.

I'm not sure that I did this particularly well in this case.  Oh well.


Please confirm that
mm-hugetlb-fix-hugepage-memory-leak-in-walk_page_range.patch is
suitable for a -stable backport without inclusion of
mm-hugetlb-add-hugepage-support-to-pagemap.patch.  I think it is.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>