From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 9532960021B for ; Tue, 8 Dec 2009 06:24:15 -0500 (EST) Date: Tue, 8 Dec 2009 12:24:12 +0100 From: Nick Piggin Subject: hwpoison madvise code Message-ID: <20091208112412.GA6038@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-linux-mm@kvack.org To: Andi Kleen , fengguang.wu@intel.com, Linux Memory Management List List-ID: Hi, Seems like the madvise hwpoison code is ugly and buggy, not to put too fine a point on it :) Ugly: it should have just followed the same pattern as the other transient advices. Buggy: it doesn't take mmap_sem. If it followed the pattern, it wouldn't have had this bug. Please fix. Thanks, Nick -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org