From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 2D13B60021B for ; Mon, 7 Dec 2009 01:17:53 -0500 (EST) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nB76HnTL015288 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Mon, 7 Dec 2009 15:17:49 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 7A31D45DE52 for ; Mon, 7 Dec 2009 15:17:49 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 5994345DE4F for ; Mon, 7 Dec 2009 15:17:49 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 3A5291DB8043 for ; Mon, 7 Dec 2009 15:17:49 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id E497A1DB803F for ; Mon, 7 Dec 2009 15:17:48 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH] vmscan: aligned scan batching In-Reply-To: <20091206054113.GA23912@localhost> References: <20091127091357.A7CC.A69D9226@jp.fujitsu.com> <20091206054113.GA23912@localhost> Message-Id: <20091207143548.E944.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Mon, 7 Dec 2009 15:17:48 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Andrew Morton , Rik van Riel List-ID: > > - pass nr_to_scan into isolate_pages() directly instead > > using SWAP_CLUSTER_MAX > > This patch will make sure nr_to_scan==SWAP_CLUSTER_MAX :) > > Thanks, > Fengguang > --- > vmscan: aligned scan batching > > Make sure ->isolate_pages() always scans in unit of SWAP_CLUSTER_MAX. > > CC: Rik van Riel > CC: KOSAKI Motohiro > Signed-off-by: Wu Fengguang > --- > mm/vmscan.c | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) Hm, Your patch always pass SWAP_CLUSTER_MAX to shrink_list(). Can we remove nr_to_scan argument of shrink_list() completely? Anyway, this diffstat itsef explain this patch's worth. I'll queue this patch into my vmscan cleanup branch. > > --- linux-mm.orig/mm/vmscan.c 2009-12-06 13:13:28.000000000 +0800 > +++ linux-mm/mm/vmscan.c 2009-12-06 13:31:21.000000000 +0800 > @@ -1572,15 +1572,11 @@ static void get_scan_ratio(struct zone * > static unsigned long nr_scan_try_batch(unsigned long nr_to_scan, > unsigned long *nr_saved_scan) > { > - unsigned long nr; > + unsigned long nr = *nr_saved_scan + nr_to_scan; > + unsigned long rem = nr & (SWAP_CLUSTER_MAX - 1); > > - *nr_saved_scan += nr_to_scan; > - nr = *nr_saved_scan; > - > - if (nr >= SWAP_CLUSTER_MAX) > - *nr_saved_scan = 0; > - else > - nr = 0; > + *nr_saved_scan = rem; > + nr -= rem; > > return nr; > } > @@ -1592,7 +1588,6 @@ static void shrink_zone(int priority, st > struct scan_control *sc) > { > unsigned long nr[NR_LRU_LISTS]; > - unsigned long nr_to_scan; > unsigned long percent[2]; /* anon @ 0; file @ 1 */ > enum lru_list l; > unsigned long nr_reclaimed = sc->nr_reclaimed; > @@ -1625,11 +1620,8 @@ static void shrink_zone(int priority, st > nr[LRU_INACTIVE_FILE]) { > for_each_evictable_lru(l) { > if (nr[l]) { > - nr_to_scan = min_t(unsigned long, > - nr[l], SWAP_CLUSTER_MAX); > - nr[l] -= nr_to_scan; > - > - nr_reclaimed += shrink_list(l, nr_to_scan, > + nr[l] -= SWAP_CLUSTER_MAX; > + nr_reclaimed += shrink_list(l, SWAP_CLUSTER_MAX, > zone, sc, priority); > } > } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org