From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 567986B0044 for ; Sun, 6 Dec 2009 21:02:27 -0500 (EST) Date: Mon, 7 Dec 2009 10:02:22 +0800 From: Wu Fengguang Subject: Re: [RFC] print symbolic page flag names in bad_page() Message-ID: <20091207020222.GB7502@localhost> References: <20091204212606.29258.98531.stgit@bob.kio> <20091206034636.GA7109@localhost> <20091206230016.GA18989@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091206230016.GA18989@one.firstfloor.org> Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Alex Chiang , "akpm@linux-foundation.org" , "Li, Haicheng" , Randy Dunlap , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Ingo Molnar , Christoph Lameter , Rik van Riel , Mel Gorman , KOSAKI Motohiro List-ID: On Mon, Dec 07, 2009 at 07:00:16AM +0800, Andi Kleen wrote: > > So how about this patch? > > I like it. Decoding the flags by hand is always a very unpleasant experience. > Bonus: dump_page can be called from kgdb too. Thank you. And I'd like to elaborate a bit more on the rational. Making the page-types tool depend on .config is fragile and dangerous. It would seem to work but silently return wrong results for a newbie user or a careless hacker. And it's troublesome even for home made kernels by a kernel developer. For example, typically I run many kernel trees with different versions and kconfigs (both of which change frequently) concurrently. This means I would have to judge to run "this" page-types or "that" page-types, and to check if this page-types is uptodate, and if the .config is in sync with the running kernel image.. An in-kernel dump_page() makes life easier. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org