From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 958DA6007BA for ; Fri, 4 Dec 2009 02:37:40 -0500 (EST) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nB47bad3013502 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 4 Dec 2009 16:37:37 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 6C0CD45DE55 for ; Fri, 4 Dec 2009 16:37:36 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 4D60545DE51 for ; Fri, 4 Dec 2009 16:37:36 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 3B2D18F8005 for ; Fri, 4 Dec 2009 16:37:36 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id E15041DF8002 for ; Fri, 4 Dec 2009 16:37:35 +0900 (JST) Date: Fri, 4 Dec 2009 16:34:41 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH -mmotm 0/7] memcg: move charge at task migration (04/Dec) Message-Id: <20091204163441.294a5ee8.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20091204160901.dac2e8bc.nishimura@mxp.nes.nec.co.jp> References: <20091204144609.b61cc8c4.nishimura@mxp.nes.nec.co.jp> <20091204155317.2d570a55.kamezawa.hiroyu@jp.fujitsu.com> <20091204160901.dac2e8bc.nishimura@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Daisuke Nishimura Cc: Andrew Morton , Balbir Singh , Li Zefan , Paul Menage , linux-mm List-ID: On Fri, 4 Dec 2009 16:09:01 +0900 Daisuke Nishimura wrote: > On Fri, 4 Dec 2009 15:53:17 +0900, KAMEZAWA Hiroyuki wrote: > > On Fri, 4 Dec 2009 14:46:09 +0900 > > Daisuke Nishimura wrote: > > > > > Hi. > > > > > > These are current patches of my move-charge-at-task-migration feature. > > > > > > The biggest change from previous(19/Nov) version is improvement in performance. > > > > > > I measured the elapsed time of "echo [pid] > /tasks" on KVM guest > > > with 4CPU/4GB(Xeon/3GHz) in three patterns: > > > > > > (1) / -> /00 > > > (2) /00 -> /01 > > > > > > we don't need to call res_counter_uncharge against root, so (1) would be smaller > > > than (2). > > > > > > (3) /00(setting mem.limit to half size of total) -> /01 > > > > > > To compare the overhead of anon and swap. > > > > > > Please read patch descriptions for each patch([4/7],[7/7]) for details of > > > how and how much the patch improved the performance. > > > > > > [1/7] cgroup: introduce cancel_attach() > > > [2/7] memcg: add interface to move charge at task migration > > > [3/7] memcg: move charges of anonymous page > > > [4/7] memcg: improbe performance in moving charge > > > [5/7] memcg: avoid oom during moving charge > > > [6/7] memcg: move charges of anonymous swap > > > [7/7] memcg: improbe performance in moving swap charge > > > > > > Current version supports only recharge of non-shared(mapcount == 1) anonymous pages > > > and swaps of those pages. I think it's enough as a first step. > > > > > Hmm. shared swap entry (very rare one?) is moved ? > > > Well, do you mean the charge of shared swap entry(IOW, swap entry with swap_count > 1) > is moved ? If so, no. I check swap_count in mem_cgroup_count_swap_user(see [6/7]), > and don't move the charge of it if it's shared. > I see. thank you for explanation. Regards, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org