From: Roger Oksanen <roger.oksanen@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>, Mel Gorman <mel@csn.ul.ie>,
Roger Oksanen <roger.oksanen@cs.helsinki.fi>
Subject: Re: [RFC,PATCH 1/2] dmapool: Don't warn when allowed to retry allocation.
Date: Wed, 2 Dec 2009 23:22:34 +0200 [thread overview]
Message-ID: <200912022322.34363.roger.oksanen@cs.helsinki.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.0912021355160.2547@router.home>
On Wednesday 02 December 2009 21:56:10 Christoph Lameter wrote:
> On Wed, 2 Dec 2009, Roger Oksanen wrote:
> > dmapool: Don't warn when allowed to retry allocation.
>
> It warns after 10 attempts even when allowed to retry? Description is not
> entirely accurate.
I left one part off by mistake. The whole descriptions should have read
"dmapool uses it's own wait logic, so allocations failing may be retried
if the called specified a waiting GFP_*. Unnecessary warnings only cause
confusion. Every 10th retry will still cause a warning, to disclose a
possible problem."
10 retries (* POOL_TIMEOUT_JIFFIES) roughly means 1s, so then I assume there
is really some problems in finding the requested memory. If the pool allocator
was allowed to fail after n retries, then that point would probably be the
best place to warn on.
best regards,
--
Roger Oksanen <roger.oksanen@cs.helsinki.fi>
http://www.cs.helsinki.fi/u/raoksane
+358 50 355 1990
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-12-02 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 13:18 [RFC,PATCH 0/2] dmapool: allocation gfp changes Roger Oksanen
2009-12-02 13:20 ` [RFC,PATCH 1/2] dmapool: Don't warn when allowed to retry allocation Roger Oksanen
2009-12-02 19:56 ` Christoph Lameter
2009-12-02 21:22 ` Roger Oksanen [this message]
2009-12-02 13:23 ` [RFC,PATCH 2/2] dmapool: Honor GFP_* flags Roger Oksanen
2009-12-02 20:00 ` Christoph Lameter
2009-12-02 21:39 ` Roger Oksanen
2009-12-02 22:05 ` Christoph Lameter
2009-12-03 12:10 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912022322.34363.roger.oksanen@cs.helsinki.fi \
--to=roger.oksanen@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox