From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id DB3FF600762 for ; Wed, 2 Dec 2009 08:44:18 -0500 (EST) Date: Wed, 2 Dec 2009 14:44:15 +0100 From: Andi Kleen Subject: Re: [PATCH 06/24] HWPOISON: abort on failed unmap Message-ID: <20091202134415.GJ18989@one.firstfloor.org> References: <20091202031231.735876003@intel.com> <20091202043044.293905787@intel.com> <20091202131150.GE18989@one.firstfloor.org> <20091202132819.GC13277@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091202132819.GC13277@localhost> Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: Andi Kleen , Andrew Morton , Nick Piggin , "linux-mm@kvack.org" , LKML List-ID: On Wed, Dec 02, 2009 at 09:28:19PM +0800, Wu Fengguang wrote: > On Wed, Dec 02, 2009 at 09:11:50PM +0800, Andi Kleen wrote: > > > * Now take care of user space mappings. > > > + * Abort on fail: __remove_from_page_cache() assumes unmapped page. > > > */ > > > - hwpoison_user_mappings(p, pfn, trapno); > > > + if (hwpoison_user_mappings(p, pfn, trapno) != SWAP_SUCCESS) { > > > + res = -EBUSY; > > > + goto out; > > > > It would be good to print something in this case. > > OK. I'll add it. > > > Did you actually see it during testing? > > Perhaps not. > > > Or maybe loop forever in the unmapper. > > !SWAP_SUCCESS should be rare, so not necessary to loop forever? I think the loop I originally added was overcautious and could be even removed possibly now. It probably needs some more analysis how l ikely unmapping failures really are. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org