From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id D3D41600762 for ; Wed, 2 Dec 2009 08:31:24 -0500 (EST) Date: Wed, 2 Dec 2009 21:31:01 +0800 From: Wu Fengguang Subject: Re: [PATCH 10/24] HWPOISON: remove the free buddy page handler Message-ID: <20091202133101.GD13277@localhost> References: <20091202031231.735876003@intel.com> <20091202043044.878843398@intel.com> <20091202131330.GF18989@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091202131330.GF18989@one.firstfloor.org> Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Andrew Morton , Nick Piggin , "linux-mm@kvack.org" , LKML List-ID: On Wed, Dec 02, 2009 at 09:13:30PM +0800, Andi Kleen wrote: > On Wed, Dec 02, 2009 at 11:12:41AM +0800, Wu Fengguang wrote: > > The buddy page has already be handled in the very beginning. > > So remove redundant code. > > I think I prefer the table to be complete, even if some of the > cases might not happen currently. A BUG() would be reasonable though. I'd prefer not to carry around some useless bytes in kernel. What if we replace it with a comment line in the table? Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org