From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: kosaki.motohiro@jp.fujitsu.com,
Jens Axboe <jens.axboe@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Frans Pop <elendil@planet.nl>, Jiri Kosina <jkosina@suse.cz>,
Sven Geggus <lists@fuchsschwanzdomain.de>,
Karol Lewandowski <karol.k.lewandowski@gmail.com>,
Tobias Oetiker <tobi@oetiker.ch>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Rik van Riel <riel@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
Stephan von Krawczynski <skraw@ithnet.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH-RFC] cfq: Disable low_latency by default for 2.6.32
Date: Fri, 27 Nov 2009 13:36:20 +0900 (JST) [thread overview]
Message-ID: <20091127133511.A7DB.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20091126121945.GB13095@csn.ul.ie>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> ---
> block/cfq-iosched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index aa1e953..dc33045 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -2543,7 +2543,7 @@ static void *cfq_init_queue(struct request_queue *q)
> cfqd->cfq_slice[1] = cfq_slice_sync;
> cfqd->cfq_slice_async_rq = cfq_slice_async_rq;
> cfqd->cfq_slice_idle = cfq_slice_idle;
> - cfqd->cfq_latency = 1;
> + cfqd->cfq_latency = 0;
> cfqd->hw_tag = 1;
> cfqd->last_end_sync_rq = jiffies;
> return cfqd;
Great. Probably we can reenable this feature at 2.6.33. but there isn't any reason to take
any risk at 2.6.32. i.e. This simple disabling is best. I like this.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-11-27 4:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 12:19 Mel Gorman
2009-11-26 13:08 ` Mike Galbraith
2009-11-26 13:20 ` Bartlomiej Zolnierkiewicz
2009-11-26 13:37 ` Mike Galbraith
2009-11-26 13:56 ` Mel Gorman
2009-11-26 13:47 ` Corrado Zoccolo
2009-11-26 14:17 ` Mel Gorman
2009-11-26 15:18 ` Corrado Zoccolo
2009-11-27 11:44 ` Mel Gorman
2009-11-27 12:03 ` Corrado Zoccolo
2009-11-27 15:58 ` Mel Gorman
2009-11-27 18:14 ` Corrado Zoccolo
2009-11-27 18:52 ` Mel Gorman
2009-11-29 15:11 ` Corrado Zoccolo
2009-11-30 12:04 ` Mel Gorman
2009-11-30 12:54 ` Corrado Zoccolo
2009-11-30 15:48 ` Mel Gorman
2009-11-30 17:21 ` Corrado Zoccolo
2009-11-27 5:58 ` KOSAKI Motohiro
2009-11-27 6:29 ` KOSAKI Motohiro
2009-11-27 12:16 ` Mel Gorman
2009-11-30 10:18 ` KOSAKI Motohiro
2009-11-27 4:36 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127133511.A7DB.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=jens.axboe@oracle.com \
--cc=jkosina@suse.cz \
--cc=karol.k.lewandowski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lists@fuchsschwanzdomain.de \
--cc=mel@csn.ul.ie \
--cc=penberg@cs.helsinki.fi \
--cc=riel@redhat.com \
--cc=rjw@sisk.pl \
--cc=skraw@ithnet.com \
--cc=tobi@oetiker.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox