From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Vincent Li <macli@brc.ubc.ca>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] [for mmotm-1113] mm: Simplify try_to_unmap_one()
Date: Thu, 19 Nov 2009 14:49:52 +0900 (JST) [thread overview]
Message-ID: <20091119144657.3E34.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0911182108260.15866@kernalhack.brc.ubc.ca>
>
> Hi KOSAKI,
>
> Thank you for the comment, I am still little confused with the last
> sentence.
>
> On Thu, 19 Nov 2009, KOSAKI Motohiro wrote:
>
> >
> > +
> > + /*
> > + * We need mmap_sem locking, Otherwise VM_LOCKED check makes
> > + * unstable result and race. Plus, We can't wait here because
> > + * we now hold anon_vma->lock or mapping->i_mmap_lock.
> > + * If trylock failed, The page remain evictable lru and
> > + * retry to more unevictable lru by later vmscan.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I am having
> trouble to undestand it. Yeah, I should read more code, but the sentence
> itself make me confused :).
Um, this is wrong.
Probably, It should be
retry to move unevictable lru later.
Do you agree this?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-11-19 5:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 8:39 KOSAKI Motohiro
2009-11-18 16:34 ` Hugh Dickins
2009-11-18 23:18 ` Andrew Morton
2009-11-19 1:23 ` KOSAKI Motohiro
2009-11-19 5:27 ` Vincent Li
2009-11-19 5:49 ` KOSAKI Motohiro [this message]
2009-11-19 6:14 ` Vincent Li
2009-11-19 6:28 ` KOSAKI Motohiro
2009-11-19 7:11 ` Vincent Li
2009-12-04 8:29 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119144657.3E34.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=macli@brc.ubc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox