From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 414746B004D for ; Wed, 18 Nov 2009 00:27:22 -0500 (EST) Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nAI5RJdZ017279 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Wed, 18 Nov 2009 14:27:20 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id A138945DE53 for ; Wed, 18 Nov 2009 14:27:19 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 72CEB45DE4F for ; Wed, 18 Nov 2009 14:27:19 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 52EC81DB8045 for ; Wed, 18 Nov 2009 14:27:19 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id F08CA1DB803F for ; Wed, 18 Nov 2009 14:27:18 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH] vmscan: Have kswapd sleep for a short interval and double check it should be asleep fix 1 In-Reply-To: <20091117103420.GX29804@csn.ul.ie> References: <2f11576a0911140134u21eafa83t9642bb25ccd953de@mail.gmail.com> <20091117103420.GX29804@csn.ul.ie> Message-Id: <20091118142111.3E12.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Wed, 18 Nov 2009 14:27:18 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , linux-kernel@vger.kernel.org, "linux-mm@kvack.org" , Pekka Enberg , Rik van Riel , Christoph Lameter , Stephan von Krawczynski , "Rafael J. Wysocki" , Kernel Testers List List-ID: > When checking if kswapd is sleeping prematurely, all populated zones are > checked instead of the zones the instance of kswapd is responsible for. > The counters for kswapd going to sleep prematurely are also named poorly. > This patch makes kswapd only check its own zones and renames the relevant > counters. > > This is a fix to the patch > vmscan-have-kswapd-sleep-for-a-short-interval-and-double-check-it-should-be-asleep.patch > and is based on top of mmotm-2009-11-13-19-59. It would be preferable if > Kosaki Motohiro signed off on it as he had comments on the patch but the > discussion petered out without a solid conclusion. > > Signed-off-by: Mel Gorman Looks good to me. I apologize to bother you by nit for long time. Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org