linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	Minchan Kim <minchan.kim@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"hugh.dickins@tiscali.co.uk" <hugh.dickins@tiscali.co.uk>,
	akpm@linux-foundation.org,
	"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH] show per-process swap usage via procfs v3
Date: Fri, 13 Nov 2009 11:35:02 +0900	[thread overview]
Message-ID: <20091113113502.9c5a93b7.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20091113105112.c72cf8f5.kamezawa.hiroyu@jp.fujitsu.com>

On Fri, 13 Nov 2009 10:51:12 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > > @@ -597,7 +600,9 @@ copy_one_pte(struct mm_struct *dst_mm, s
> > >  						 &src_mm->mmlist);
> > >  				spin_unlock(&mmlist_lock);
> > >  			}
> > > -			if (is_write_migration_entry(entry) &&
> > > +			if (!non_swap_entry(entry))
> > > +				rss[2]++;
> > > +			else if (is_write_migration_entry(entry) &&
> > >  					is_cow_mapping(vm_flags)) {
> > >  				/*
> > 
> > What are the implications for fork performance?
> 
> This path is executed when page table entry contains a entry of
>   !pte_none() && !pte_present().
> 
> There are not very big chance to reach here.(this path is under unlikely()).
> 

[before]
 text    data     bss     dec     hex filename
6649003 3221828 10232816        20103647        132c1df vmlinux
[after]
   text    data     bss     dec     hex filename
6649243 3221828 10232816        20103887        132c2cf vmlinux

Now, 240 bytes of text size..Hmm.

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2009-11-13  2:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04  6:24 [PATCH] show per-process swap usage via procfs KAMEZAWA Hiroyuki
2009-11-04 19:15 ` Christoph Lameter
2009-11-04 23:25   ` KOSAKI Motohiro
2009-11-05  2:28     ` KAMEZAWA Hiroyuki
2009-11-05 15:04     ` Christoph Lameter
2009-11-08 17:04       ` Pavel Machek
2009-11-05  0:06   ` KAMEZAWA Hiroyuki
2009-11-05  5:16     ` [RFC][PATCH] lib: generic percpu counter array KAMEZAWA Hiroyuki
2009-11-05 15:15       ` Christoph Lameter
2009-11-06  0:49         ` KAMEZAWA Hiroyuki
2009-11-05 15:20       ` Christoph Lameter
2009-11-06  0:56         ` KAMEZAWA Hiroyuki
2009-11-05 14:41 ` [PATCH] show per-process swap usage via procfs KOSAKI Motohiro
2009-11-05 15:11 ` Minchan Kim
2009-11-05 23:48   ` KAMEZAWA Hiroyuki
2009-11-06  4:40     ` [PATCH] show per-process swap usage via procfs v2 KAMEZAWA Hiroyuki
2009-11-06 15:19       ` Minchan Kim
2009-11-11  2:25         ` [PATCH] show per-process swap usage via procfs v3 KAMEZAWA Hiroyuki
2009-11-12 15:20           ` Christoph Lameter
2009-11-13  1:51             ` KAMEZAWA Hiroyuki
2009-11-13  2:35               ` KAMEZAWA Hiroyuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113113502.9c5a93b7.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox