From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id F139D6B004D for ; Tue, 10 Nov 2009 20:22:16 -0500 (EST) Received: from m4.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nAB1MAwl007076 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Wed, 11 Nov 2009 10:22:10 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 1CE2645DE6F for ; Wed, 11 Nov 2009 10:22:10 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id F140145DE4D for ; Wed, 11 Nov 2009 10:22:09 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id D9CED1DB803B for ; Wed, 11 Nov 2009 10:22:09 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 9556A1DB803A for ; Wed, 11 Nov 2009 10:22:09 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 3/6] mm: CONFIG_MMU for PG_mlocked In-Reply-To: References: Message-Id: <20091111101315.FD33.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Wed, 11 Nov 2009 10:22:08 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , Izik Eidus , Andrea Arcangeli , Nick Piggin , Rik van Riel , Lee Schermerhorn , Andi Kleen , Wu Fengguang , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: > Remove three degrees of obfuscation, left over from when we had > CONFIG_UNEVICTABLE_LRU. MLOCK_PAGES is CONFIG_HAVE_MLOCKED_PAGE_BIT > is CONFIG_HAVE_MLOCK is CONFIG_MMU. rmap.o (and memory-failure.o) > are only built when CONFIG_MMU, so don't need such conditions at all. > > Somehow, I feel no compulsion to remove the CONFIG_HAVE_MLOCK* > lines from 169 defconfigs: leave those to evolve in due course. > > Signed-off-by: Hugh Dickins I don't recall why Lee added this config option. but it seems very reasonable and I storongly like it. At least, vmscan folks never said "please try to disable CONFIG_MLOCK". It mean this option didn't help our debug. Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org