From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 93D536B004D for ; Tue, 10 Nov 2009 03:04:56 -0500 (EST) Date: Tue, 10 Nov 2009 17:03:38 +0900 From: Daisuke Nishimura Subject: Re: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v2 Message-Id: <20091110170338.9f3bb417.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20091110164055.a1b44a4b.kamezawa.hiroyu@jp.fujitsu.com> References: <20091110162121.361B.A69D9226@jp.fujitsu.com> <20091110162445.c6db7521.kamezawa.hiroyu@jp.fujitsu.com> <20091110163419.361E.A69D9226@jp.fujitsu.com> <20091110164055.a1b44a4b.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: KOSAKI Motohiro , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , cl@linux-foundation.org, rientjes@google.com, Daisuke Nishimura List-ID: On Tue, 10 Nov 2009 16:40:55 +0900, KAMEZAWA Hiroyuki wrote: > On Tue, 10 Nov 2009 16:39:02 +0900 (JST) > KOSAKI Motohiro wrote: > > > > > > + > > > > > + /* Check this allocation failure is caused by cpuset's wall function */ > > > > > + for_each_zone_zonelist_nodemask(zone, z, zonelist, > > > > > + high_zoneidx, nodemask) > > > > > + if (!cpuset_zone_allowed_softwall(zone, gfp_mask)) > > > > > return CONSTRAINT_CPUSET; > > > > > > > > If cpuset and MPOL_BIND are both used, Probably CONSTRAINT_MEMORY_POLICY is > > > > better choice. > > > > > > No. this memory allocation is failed by limitation of cpuset's alloc mask. > > > Not from mempolicy. > > > > But CONSTRAINT_CPUSET doesn't help to free necessary node memory. It isn't > > your fault. original code is wrong too. but I hope we should fix it. > > I think so too. > Hmm, maybe fair enough. > > My 3rd version will use "kill always current(CONSTRAINT_MEMPOLICY does this) > if it uses mempolicy" logic. > "if it uses mempoicy" ? You mean "kill allways current if memory allocation has failed by limitation of cpuset's mask"(i.e. CONSTRAINT_CPUSET case) ? Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org