From: Rusty Russell <rusty@rustcorp.com.au>
To: paulmck@linux.vnet.ibm.com
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Gregory Haskins <gregory.haskins@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
akpm@linux-foundation.org, hpa@zytor.com, s.hetze@linux-ag.com
Subject: Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
Date: Fri, 6 Nov 2009 15:31:20 +1030 [thread overview]
Message-ID: <200911061531.20299.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091104172542.GC6736@linux.vnet.ibm.com>
On Thu, 5 Nov 2009 03:55:42 am Paul E. McKenney wrote:
> On Wed, Nov 04, 2009 at 01:57:29PM +0200, Michael S. Tsirkin wrote:
> > Can you ack this usage please?
>
> I thought I had done so in my paragraph above, but if you would like
> something a bit more formal...
<snip verbose super-ack with qualifications>
That's great guys. And yes, this is a kind of read-copy-update. And no,
there's nothing wrong with it.
But it's still nasty to use half an API. If it were a few places I would
have open-coded it with a comment, or wrapped it. As it is, I don't think
that would be a win.
Cheers,
Rusty.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-11-06 5:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257267892.git.mst@redhat.com>
2009-11-03 17:24 ` [PATCHv7 1/3] tun: export underlying socket Michael S. Tsirkin
2009-11-04 13:30 ` David Miller
2009-11-03 17:24 ` [PATCHv7 2/3] mm: export use_mm/unuse_mm to modules Michael S. Tsirkin
2009-11-03 17:32 ` Gregory Haskins
2009-11-03 17:24 ` [PATCHv7 3/3] vhost_net: a kernel-level virtio server Michael S. Tsirkin
2009-11-03 18:03 ` Eric Dumazet
2009-11-03 18:08 ` Gregory Haskins
2009-11-03 18:14 ` Gregory Haskins
2009-11-03 18:51 ` Eric Dumazet
2009-11-03 19:50 ` Gregory Haskins
2009-11-03 19:58 ` Michael S. Tsirkin
2009-11-03 21:11 ` Eric Dumazet
2009-11-04 12:04 ` Michael S. Tsirkin
2009-11-03 23:57 ` Paul E. McKenney
2009-11-04 11:57 ` Michael S. Tsirkin
2009-11-04 17:25 ` Paul E. McKenney
2009-11-04 17:33 ` Eric Dumazet
2009-11-04 19:06 ` Michael S. Tsirkin
2009-11-04 19:12 ` Gregory Haskins
2009-11-06 5:01 ` Rusty Russell [this message]
2009-11-06 16:30 ` Paul E. McKenney
2009-11-08 4:09 ` Rusty Russell
2009-11-08 19:36 ` Paul E. McKenney
2009-11-03 19:55 ` Michael S. Tsirkin
2009-11-04 11:08 ` Andi Kleen
2009-11-04 12:10 ` Michael S. Tsirkin
2009-11-04 12:59 ` Andi Kleen
2009-11-04 13:08 ` Michael S. Tsirkin
2009-11-04 13:15 ` Andi Kleen
2009-11-04 13:17 ` Michael S. Tsirkin
2009-11-04 13:37 ` Andi Kleen
2009-11-04 13:41 ` Michael S. Tsirkin
2009-11-04 16:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911061531.20299.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=gregory.haskins@gmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=s.hetze@linux-ag.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox