From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 902D26B0044 for ; Thu, 5 Nov 2009 06:32:56 -0500 (EST) From: Arnd Bergmann Subject: Re: [PATCHv6 1/3] tun: export underlying socket Date: Thu, 5 Nov 2009 12:30:43 +0100 References: <200911041909.06054.arnd@arndb.de> <20091104190523.GA772@redhat.com> In-Reply-To: <20091104190523.GA772@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200911051230.43272.arnd@arndb.de> Sender: owner-linux-mm@kvack.org To: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org, akpm@linux-foundation.org, hpa@zytor.com, gregory.haskins@gmail.com, Rusty Russell , s.hetze@linux-ag.com List-ID: On Wednesday 04 November 2009, Michael S. Tsirkin wrote: > > > > Michael, you didn't reply on this comment and the code is still there in v8. > > Do you actually need this? What for? > > > > Arnd <>< > > Sorry, missed the question. If you look closely it is not exported for > !__KERNEL__ at all. The stub is for when CONFIG_TUN is undefined. > Maybe I'll add a comment near #else, even though this is a bit strange > since the #if is just 2 lines above it. Ah right, I'm just blind. Don't bother changing it then, the code looks good as it is. Arnd <>< -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org