From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 985A06B0044 for ; Thu, 5 Nov 2009 03:27:41 -0500 (EST) Date: Thu, 5 Nov 2009 09:27:35 +0100 From: Andi Kleen Subject: Re: [MM] Remove rss batching from copy_page_range() Message-ID: <20091105082735.GP31511@one.firstfloor.org> References: <87my3280mb.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Andi Kleen , KAMEZAWA Hiroyuki , "hugh.dickins@tiscali.co.uk" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Tejun Heo List-ID: On Wed, Nov 04, 2009 at 05:02:12PM -0500, Christoph Lameter wrote: > On Wed, 4 Nov 2009, Andi Kleen wrote: > > > > With per cpu counters in mm there is no need for batching > > > mm counter updates anymore. Update counters directly while > > > copying pages. > > > > Hmm, but with all the inlining with some luck the local > > counters will be in registers. That will never be the case > > with the per cpu counters. > > The function is too big for that to occur and the counters have to be If it's only called once then gcc doesn't care about size. > preserved across function calls. The code is shorter with the patch > applied: I see. Thanks for the data. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org