From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 3FACB6B0044 for ; Wed, 4 Nov 2009 02:46:15 -0500 (EST) From: Rusty Russell Subject: Re: [PATCH 1/1] MM: slqb, fix per_cpu access Date: Wed, 4 Nov 2009 18:15:52 +1030 References: <1257113578-1584-1-git-send-email-jirislaby@gmail.com> <200911022353.30524.rusty@rustcorp.com.au> <4AEEFB5D.9080009@gmail.com> In-Reply-To: <4AEEFB5D.9080009@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911041815.53431.rusty@rustcorp.com.au> Sender: owner-linux-mm@kvack.org To: Jiri Slaby Cc: npiggin@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter List-ID: On Tue, 3 Nov 2009 02:01:41 am Jiri Slaby wrote: > >> - struct delayed_work *cache_trim_work = &per_cpu(cache_trim_work, cpu); > >> + struct delayed_work *_cache_trim_work = &per_cpu(cache_trim_work, cpu); > >> > >> /* > >> * When this gets called from do_initcalls via cpucache_init(), > >> * init_workqueues() has already run, so keventd will be setup > >> * at that time. > >> */ > >> - if (keventd_up() && cache_trim_work->work.func == NULL) { > >> - INIT_DELAYED_WORK(cache_trim_work, cache_trim_worker); > >> - schedule_delayed_work_on(cpu, cache_trim_work, > >> + if (keventd_up() && _cache_trim_work->work.func == NULL) { > >> + INIT_DELAYED_WORK(_cache_trim_work, cache_trim_worker); > >> + schedule_delayed_work_on(cpu, _cache_trim_work, > >> __round_jiffies_relative(HZ, cpu)); > > > > How about calling the local var "trim"? > > > > This actually makes the code more readable, IMHO. > > Please ignore this version of the patch. After this I sent a new one > which changes the global var name. OK, sure. It's not worth changing unless you were doing a rename anyway. > So the local variable is untouched there. If you want me to perform the > cleanup, let me know. In any case I'd make it trim_work instead of trim > which makes more sense to me. This is getting pedantic and marginal, but the word "work" already appears everywhere this var is used. Either "XXX->work", or "INIT_DELAYED_WORK(XXX" or "scheduled_delayed_work_on(cpu, XXX". That's why I think the word "work" in unnecessary. Hope that clarifies why I preferred "trim". Rusty. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org