From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 91F646B006A for ; Mon, 2 Nov 2009 04:22:27 -0500 (EST) Date: Mon, 2 Nov 2009 10:22:14 +0100 From: Ingo Molnar Subject: Re: [PATCH 02/11] Add "handle page fault" PV helper. Message-ID: <20091102092214.GB8933@elte.hu> References: <1257076590-29559-1-git-send-email-gleb@redhat.com> <1257076590-29559-3-git-send-email-gleb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1257076590-29559-3-git-send-email-gleb@redhat.com> Sender: owner-linux-mm@kvack.org To: Gleb Natapov Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Thomas Gleixner List-ID: * Gleb Natapov wrote: > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index f4cee90..14707dc 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -952,6 +952,9 @@ do_page_fault(struct pt_regs *regs, unsigned long error_code) > int write; > int fault; > > + if (arch_handle_page_fault(regs, error_code)) > + return; > + This patch is not acceptable unless it's done cleaner. Currently we already have 3 callbacks in do_page_fault() (kmemcheck, mmiotrace, notifier), and this adds a fourth one. Please consolidate them into a single callback site, this is a hotpath on x86. And please always Cc: the x86 maintainers to patches that touch x86 code. Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org