From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id DC8056B004D for ; Wed, 28 Oct 2009 14:39:08 -0400 (EDT) Date: Wed, 28 Oct 2009 12:39:05 -0600 From: Alex Chiang Subject: Re: [PATCH v2 1/5] mm: add numa node symlink for memory section in sysfs Message-ID: <20091028183905.GF22743@ldl.fc.hp.com> References: <20091022040814.15705.95572.stgit@bob.kio> <20091022041510.15705.5410.stgit@bob.kio> <20091027195907.GJ14102@ldl.fc.hp.com> <20091028083137.GA24140@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: Heiko Carstens , Andrew Morton , Gary Hade , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Badari Pulavarty , Martin Schwidefsky , Ingo Molnar List-ID: * David Rientjes : > > Alex, I think the safest thing to do in unregister_mem_sect_under_nodes() > is to iterate though the section pfns and remove links to the node_device > kobjs for all the distinct pfn_to_nid()'s that it encounters. Am I not understanding the code? It looks like we do this already... /* unregister memory section under all nodes that it spans */ int unregister_mem_sect_under_nodes(struct memory_block *mem_blk) { nodemask_t unlinked_nodes; unsigned long pfn, sect_start_pfn, sect_end_pfn; if (!mem_blk) return -EFAULT; nodes_clear(unlinked_nodes); sect_start_pfn = section_nr_to_pfn(mem_blk->phys_index); sect_end_pfn = sect_start_pfn + PAGES_PER_SECTION - 1; for (pfn = sect_start_pfn; pfn <= sect_end_pfn; pfn++) { int nid; nid = get_nid_for_pfn(pfn); if (nid < 0) continue; if (!node_online(nid)) continue; if (node_test_and_set(nid, unlinked_nodes)) continue; sysfs_remove_link(&node_devices[nid].sysdev.kobj, kobject_name(&mem_blk->sysdev.kobj)); sysfs_remove_link(&mem_blk->sysdev.kobj, kobject_name(&node_devices[nid].sysdev.kobj)); } return 0; } Thanks, /ac -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org