From: Mel Gorman <mel@csn.ul.ie>
To: Frans Pop <elendil@planet.nl>, Jiri Kosina <jkosina@suse.cz>,
Sven Geggus <lists@fuchsschwanzdomain.de>,
Karol Lewandowski <karol.k.lewandowski@gmail.com>,
Tobias Oetiker <tobi@oetiker.ch>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
David Miller <davem@davemloft.net>,
Reinette Chatre <reinette.chatre@intel.com>,
Kalle Valo <kalle.valo@iki.fi>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mohamed Abbas <mohamed.abbas@intel.com>,
Jens Axboe <jens.axboe@oracle.com>,
"John W. Linville" <linville@tuxdriver.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Stephan von Krawczynski <skraw@ithnet.com>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: [PATCH 1/5 Against 2.6.31.4] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed
Date: Thu, 22 Oct 2009 15:24:17 +0100 [thread overview]
Message-ID: <20091022142417.GO11778@csn.ul.ie> (raw)
In-Reply-To: <1256221356-26049-2-git-send-email-mel@csn.ul.ie>
This is a version that applies against 2.6.31.4
==== CUT HERE ====
page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed
If a direct reclaim makes no forward progress, it considers whether it
should go OOM or not. Whether OOM is triggered or not, it may retry the
application afterwards. In times past, this would always wake kswapd as well
but currently, kswapd is not woken up after direct reclaim fails. For order-0
allocations, this makes little difference but if there is a heavy mix of
higher-order allocations that direct reclaim is failing for, it might mean
that kswapd is not rewoken for higher orders as much as it did previously.
This patch wakes up kswapd when an allocation is being retried after a direct
reclaim failure. It would be expected that kswapd is already awake, but
this has the effect of telling kswapd to reclaim at the higher order as well.
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
---
mm/page_alloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0b3c6cb..239677a 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1763,6 +1763,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
if (NUMA_BUILD && (gfp_mask & GFP_THISNODE) == GFP_THISNODE)
goto nopage;
+restart:
wake_all_kswapd(order, zonelist, high_zoneidx);
/*
@@ -1772,7 +1773,6 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
*/
alloc_flags = gfp_to_alloc_flags(gfp_mask);
-restart:
/* This is the last chance, in general, before the goto nopage. */
page = get_page_from_freelist(gfp_mask, nodemask, order, zonelist,
high_zoneidx, alloc_flags & ~ALLOC_NO_WATERMARKS,
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-22 14:24 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 14:22 [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 Mel Gorman
2009-10-22 14:22 ` [PATCH 1/5] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed Mel Gorman
2009-10-22 14:24 ` Mel Gorman [this message]
2009-10-22 14:41 ` Pekka Enberg
2009-10-22 15:49 ` Mel Gorman
2009-10-26 1:11 ` KOSAKI Motohiro
2009-10-26 7:10 ` David Rientjes
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-27 12:27 ` Mel Gorman
2009-10-22 14:22 ` [PATCH 2/5] page allocator: Do not allow interrupts to use ALLOC_HARDER Mel Gorman
2009-10-22 16:33 ` Stephan von Krawczynski
2009-10-22 16:37 ` Mel Gorman
2009-10-23 9:57 ` Stephan von Krawczynski
2009-10-24 2:03 ` Christoph Lameter
2009-10-27 15:19 ` Mel Gorman
2009-10-25 12:57 ` Stephan von Krawczynski
2009-10-26 1:15 ` KOSAKI Motohiro
2009-10-22 14:22 ` [PATCH 3/5] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit Mel Gorman
2009-10-23 17:52 ` Vincent Li
2009-10-23 22:12 ` Vincent Li
2009-10-27 10:38 ` Mel Gorman
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-22 14:22 ` [PATCH 4/5] page allocator: Pre-emptively wake kswapd when high-order watermarks are hit Mel Gorman
2009-10-22 19:41 ` David Rientjes
2009-10-23 9:13 ` Mel Gorman
2009-10-23 9:36 ` David Rientjes
2009-10-23 11:25 ` Mel Gorman
2009-10-23 11:31 ` Tobias Oetiker
2009-10-23 13:39 ` Mel Gorman
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-27 15:26 ` Mel Gorman
2009-10-22 14:22 ` [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING Revert 373c0a7e, 8aa7e847: Fix congestion_wait() sync/async vs read/write confusion Mel Gorman
2009-10-22 14:25 ` Against 2.6.31.4 [PATCH 5/5] " Mel Gorman
2009-10-22 21:49 ` [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING " Jens Axboe
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-27 10:29 ` Frans Pop
2009-10-22 14:47 ` [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 Pekka Enberg
2009-10-22 16:03 ` Mel Gorman
2009-10-24 1:52 ` Christoph Lameter
2009-10-24 6:48 ` Pekka Enberg
2009-10-24 6:48 ` Pekka Enberg
2009-10-22 15:43 ` reinette chatre
2009-10-27 10:40 ` Mel Gorman
2009-10-27 23:34 ` reinette chatre
2009-10-23 7:31 ` Sven Geggus
2009-10-23 16:58 ` Karol Lewandowski
2009-10-23 21:12 ` Karol Lewandowski
2009-10-24 13:46 ` Mel LKML
2009-10-28 11:42 ` Karol Lewandowski
2009-10-28 11:59 ` Mel Gorman
2009-10-30 14:23 ` Karol Lewandowski
2009-11-02 20:30 ` Mel Gorman
2009-11-04 2:03 ` Karol Lewandowski
2009-10-28 12:55 ` Tobi Oetiker
2009-10-24 13:51 ` Frans Pop
2009-10-24 14:02 ` Sven Geggus
2009-10-27 13:27 ` Mel Gorman
2009-10-26 17:37 ` Tobias Oetiker
2009-10-27 15:36 ` Mel Gorman
2009-10-26 22:17 ` Frans Pop
2009-10-26 23:45 ` Frans Pop
2009-11-06 6:03 ` Tobias Diedrich
2009-11-06 9:24 ` Mel Gorman
2009-11-06 9:24 ` Mel Gorman
2009-11-06 11:15 ` Tobias Diedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022142417.GO11778@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=jkosina@suse.cz \
--cc=kalle.valo@iki.fi \
--cc=karol.k.lewandowski@gmail.com \
--cc=kernel-testers@vger.kernel.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linville@tuxdriver.com \
--cc=lists@fuchsschwanzdomain.de \
--cc=mohamed.abbas@intel.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=reinette.chatre@intel.com \
--cc=rientjes@google.com \
--cc=rjw@sisk.pl \
--cc=skraw@ithnet.com \
--cc=tobi@oetiker.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox