From: Wu Fengguang <fengguang.wu@intel.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Vincent Li <root@brc.ubc.ca>, Vincent Li <macli@brc.ubc.ca>,
Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>,
"riel@redhat.com" <riel@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RESEND][PATCH V1] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.
Date: Fri, 16 Oct 2009 10:20:11 +0800 [thread overview]
Message-ID: <20091016022011.GA22706@localhost> (raw)
In-Reply-To: <20091016111041.6ffc59c9.minchan.kim@barrios-desktop>
On Fri, Oct 16, 2009 at 10:10:41AM +0800, Minchan Kim wrote:
> Hi, Vicent.
> First of all, Thanks for your effort. :)
That's pretty serious efforts ;)
> But as your data said, on usual case, nr_taken_zero count is much less
> than non_zero. so we could lost benefit in normal case due to compare
> insturction although it's trivial.
>
> I have no objection in this patch since overhead is not so big.
> But I am not sure what other guys think about it.
>
> How about adding unlikely following as ?
>
> +
> + if (unlikely(nr_taken == 0))
> + goto done;
I would prefer to just remove it - to make the code simple :)
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-16 2:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 23:49 Vincent Li
2009-09-03 21:06 ` Andrew Morton
2009-09-03 22:02 ` Vincent Li
2009-09-03 22:47 ` Andrew Morton
2009-09-04 21:39 ` Vincent Li
2009-09-04 23:53 ` Andrew Morton
2009-09-08 13:21 ` Mel Gorman
2009-09-08 22:39 ` Vincent Li
2009-09-08 23:27 ` Minchan Kim
2009-10-15 22:47 ` Vincent Li
2009-10-15 23:13 ` Vincent Li
2009-10-16 2:10 ` Minchan Kim
2009-10-16 2:20 ` Wu Fengguang [this message]
2009-10-16 3:05 ` KOSAKI Motohiro
2009-10-16 3:26 ` Vincent Li
2009-11-26 4:56 ` KOSAKI Motohiro
2009-09-09 9:59 ` Mel Gorman
2009-09-04 1:37 ` Minchan Kim
2009-09-04 2:01 ` Andrew Morton
2009-09-04 5:01 ` Vincent Li
2009-09-04 16:05 ` Vincent Li
2009-09-06 23:38 ` KOSAKI Motohiro
2009-09-08 18:32 ` Vincent Li
2009-09-08 23:47 ` KOSAKI Motohiro
2009-09-09 12:04 ` Johannes Weiner
2009-09-09 13:22 ` Minchan Kim
2009-09-22 21:02 ` Andrew Morton
2009-09-22 23:01 ` Vincent Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091016022011.GA22706@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=macli@brc.ubc.ca \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=root@brc.ubc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox