From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 82CB56B004D for ; Wed, 30 Sep 2009 19:12:06 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n8UNYe1H011115 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Thu, 1 Oct 2009 08:34:40 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 55B4145DE4D for ; Thu, 1 Oct 2009 08:34:40 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 2DF2945DE4F for ; Thu, 1 Oct 2009 08:34:40 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1587C1DB803F for ; Thu, 1 Oct 2009 08:34:40 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id BDB9E1DB8038 for ; Thu, 1 Oct 2009 08:34:36 +0900 (JST) Date: Thu, 1 Oct 2009 08:31:33 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 1/2] percpu array counter like vmstat Message-Id: <20091001083133.429f373b.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090930190943.8f19c48b.kamezawa.hiroyu@jp.fujitsu.com> References: <20090930190417.8823fa44.kamezawa.hiroyu@jp.fujitsu.com> <20090930190943.8f19c48b.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" , "linux-kernel@vger.kernel.org" List-ID: On Wed, 30 Sep 2009 19:09:43 +0900 KAMEZAWA Hiroyuki wrote: > +int array_counter_init(struct array_counter *ac, int size) > +{ > + ac->v.elements = size; > + ac->v.counters = alloc_percpu(s8); This is a bug, of course... should be ac->v.counters = __alloc_percpu(size, __alignof__(char)); Regads, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org