linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Huang Shijie <shijie8@gmail.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] memory : adjust the ugly comment
Date: Fri, 25 Sep 2009 11:19:13 -0700	[thread overview]
Message-ID: <20090925111913.c7c32a06.akpm@linux-foundation.org> (raw)
In-Reply-To: <1253870451-4887-1-git-send-email-shijie8@gmail.com>

On Fri, 25 Sep 2009 17:20:51 +0800 Huang Shijie <shijie8@gmail.com> wrote:

> The origin comment is too ugly, so modify it more beautiful.
> 
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
> ---
>  mm/memory.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 7e91b5f..6a38caa 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2405,7 +2405,10 @@ restart:
>  }
>  
>  /**
> - * unmap_mapping_range - unmap the portion of all mmaps in the specified address_space corresponding to the specified page range in the underlying file.
> + * unmap_mapping_range - unmap the portion of all mmaps in the specified
> + *	 		address_space corresponding to the specified page range
> + * 			in the underlying file.
> + *

The comment must all be in a single line so that the kerneldoc tools
process it correctly.  It's a kerneldoc restriction which all are
welcome to fix ;)


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-09-25 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25  9:20 Huang Shijie
2009-09-25 18:19 ` Andrew Morton [this message]
2009-09-25 18:27   ` Randy Dunlap
2009-09-25 18:52     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090925111913.c7c32a06.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox