linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
To: linux-mm <linux-mm@kvack.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
	Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Subject: [PATCH 6/8] memcg: migrate charge of shmem
Date: Thu, 17 Sep 2009 11:27:37 +0900	[thread overview]
Message-ID: <20090917112737.57fc2fba.nishimura@mxp.nes.nec.co.jp> (raw)
In-Reply-To: <20090917112304.6cd4e6f6.nishimura@mxp.nes.nec.co.jp>

This patch adds some checks to enable migration charge of shmem(and mmapd tmpfs file).

Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
---
 mm/memcontrol.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 830fa71..f46fd19 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2844,6 +2844,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft,
 
 enum migrate_charge_type {
 	MIGRATE_CHARGE_ANON,
+	MIGRATE_CHARGE_SHMEM,
 	NR_MIGRATE_CHARGE_TYPE,
 };
 
@@ -3210,6 +3211,8 @@ static int migrate_charge_prepare_pte_range(pmd_t *pmd,
 	pte_t *pte, ptent;
 	spinlock_t *ptl;
 	bool move_anon = (mc->to->migrate_charge & (1 << MIGRATE_CHARGE_ANON));
+	bool move_shmem = (mc->to->migrate_charge &
+					(1 << MIGRATE_CHARGE_SHMEM));
 
 	lru_add_drain_all();
 	pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl);
@@ -3226,6 +3229,8 @@ static int migrate_charge_prepare_pte_range(pmd_t *pmd,
 
 		if (PageAnon(page) && move_anon)
 			;
+		else if (!PageAnon(page) && PageSwapBacked(page) && move_shmem)
+			;
 		else
 			continue;
 
@@ -3281,6 +3286,8 @@ static int migrate_charge_prepare(void)
 	int ret = 0;
 	struct mm_struct *mm;
 	struct vm_area_struct *vma;
+	bool move_shmem = (mc->to->migrate_charge &
+					(1 << MIGRATE_CHARGE_SHMEM));
 
 	mm = get_task_mm(mc->tsk);
 	if (!mm)
@@ -3299,8 +3306,7 @@ static int migrate_charge_prepare(void)
 		}
 		if (is_vm_hugetlb_page(vma))
 			continue;
-		/* We migrate charge of private pages for now */
-		if (vma->vm_flags & (VM_SHARED | VM_MAYSHARE))
+		if (vma->vm_flags & (VM_SHARED | VM_MAYSHARE) && !move_shmem)
 			continue;
 		if (mc->to->migrate_charge) {
 			ret = walk_page_range(vma->vm_start, vma->vm_end,

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-09-17  3:11 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17  2:23 [RFC][EXPERIMENTAL][PATCH 0/8] memcg: migrate charge at task move Daisuke Nishimura
2009-09-17  2:24 ` [PATCH 1/8] memcg: introduce mem_cgroup_cancel_charge() Daisuke Nishimura
2009-09-17  4:12   ` KAMEZAWA Hiroyuki
2009-09-17  2:24 ` [PATCH 2/8] memcg: cleanup mem_cgroup_move_parent() Daisuke Nishimura
2009-09-17  4:15   ` KAMEZAWA Hiroyuki
2009-09-17  2:25 ` [PATCH 3/8] cgroup: introduce cancel_attach() Daisuke Nishimura
2009-09-17  2:26 ` [PATCH 4/8] memcg: add interface to migrate charge Daisuke Nishimura
2009-09-17  4:20   ` KAMEZAWA Hiroyuki
2009-09-17  4:40     ` Daisuke Nishimura
2009-09-17  2:26 ` [PATCH 5/8] memcg: migrate charge of anon Daisuke Nishimura
2009-09-17  4:57   ` KAMEZAWA Hiroyuki
2009-09-17  5:56     ` Daisuke Nishimura
2009-09-17  6:25       ` KAMEZAWA Hiroyuki
2009-09-17 23:52     ` KOSAKI Motohiro
2009-09-17  2:27 ` Daisuke Nishimura [this message]
2009-09-17  5:02   ` [PATCH 6/8] memcg: migrate charge of shmem KAMEZAWA Hiroyuki
2009-09-17  2:28 ` [PATCH 7/8] memcg: migrate charge of swap Daisuke Nishimura
2009-09-17  5:25   ` KAMEZAWA Hiroyuki
2009-09-17  6:17     ` Daisuke Nishimura
2009-09-17  6:28       ` KAMEZAWA Hiroyuki
2009-09-17  2:29 ` [PATCH 8/8] memcg: avoid oom during charge migration Daisuke Nishimura
2009-09-17  7:01 ` [RFC][EXPERIMENTAL][PATCH 0/8] memcg: migrate charge at task move Daisuke Nishimura
2009-09-24  5:42   ` [RFC][PATCH 0/8] memcg: migrate charge at task move (24/Sep) Daisuke Nishimura
2009-09-24  5:43     ` [RFC][PATCH 1/8] cgroup: introduce cancel_attach() Daisuke Nishimura
2009-09-24  6:33       ` KAMEZAWA Hiroyuki
2009-09-24 23:39         ` Daisuke Nishimura
2009-09-24  5:44     ` [RFC][PATCH 2/8] memcg: introduce mem_cgroup_cancel_charge() Daisuke Nishimura
2009-09-24  5:46     ` [RFC][PATCH 3/8] memcg: cleanup mem_cgroup_move_parent() Daisuke Nishimura
2009-09-24  6:37       ` KAMEZAWA Hiroyuki
2009-09-24  6:54         ` Daisuke Nishimura
2009-09-24  5:47     ` [RFC][PATCH 4/8] memcg: add interface to migrate charge Daisuke Nishimura
2009-09-24  6:54       ` KAMEZAWA Hiroyuki
2009-09-24 23:39         ` Daisuke Nishimura
2009-09-24  5:48     ` [RFC][PATCH 5/8] memcg: migrate charge of mapped page Daisuke Nishimura
2009-09-24  7:22       ` KAMEZAWA Hiroyuki
2009-09-24  8:00         ` Daisuke Nishimura
2009-09-25  0:28           ` Daisuke Nishimura
2009-09-25  0:49             ` KAMEZAWA Hiroyuki
2009-09-24  5:49     ` [RFC][PATCH 6/8] memcg: avoid oom during charge migration Daisuke Nishimura
2009-09-24  7:34       ` KAMEZAWA Hiroyuki
2009-09-25  1:44         ` Daisuke Nishimura
2009-09-25  1:55           ` KAMEZAWA Hiroyuki
2009-09-25  4:51             ` Daisuke Nishimura
2009-09-25  5:36               ` Daisuke Nishimura
2009-09-25  5:52                 ` KAMEZAWA Hiroyuki
2009-09-24  5:49     ` [RFC][PATCH 7/8] memcg: migrate charge of swap Daisuke Nishimura
2009-09-24  5:50     ` [RFC][PATCH 8/8] memcg: migrate charge of shmem swap Daisuke Nishimura
2009-09-24  7:41       ` KAMEZAWA Hiroyuki
2009-09-25  0:28         ` Daisuke Nishimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090917112737.57fc2fba.nishimura@mxp.nes.nec.co.jp \
    --to=nishimura@mxp.nes.nec.co.jp \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox