From: Mel Gorman <mel@csn.ul.ie>
To: Alexey Korolev <akorolex@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Munson <linux-mm@mgebm.net>,
Alexey Korolev <akorolev@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: HugeTLB: Driver example
Date: Thu, 17 Sep 2009 10:14:08 +0100 [thread overview]
Message-ID: <20090917091408.GB13002@csn.ul.ie> (raw)
In-Reply-To: <202cde0e0909162342xb2a8daeia90b33a172fc714b@mail.gmail.com>
On Thu, Sep 17, 2009 at 06:42:20PM +1200, Alexey Korolev wrote:
> >> There is an example of simple driver which provides huge pages mapping
> >> for user level applications. The procedure for mapping of huge pages
> >> to userspace by the driver is:
> >>
> >> 1. Create a hugetlb file on vfs mount of hugetlbfs (h_file)
> >
> > Note that to get your support code included at all you'll need a real
> > intree driver, not just an example. That is if VM people are happy with
> > the general concept.
>
> Hi,
> The driver example listed here takes the same approach as already done
> inside ipc/shm.c. So people can refer this file for development. The
> patches just make existing functions more usable by drivers and this
> example is an extract of ipc/shm.c in order to give pretty simple
> how-to.
I think Christoph's point is that there should be an in-kernel user of the
altered interface to hugetlbfs before the patches are merged. This example
driver could move to samples/ and then add another patch converting some
existing driver to use the new interface. Looking at the example driver,
I'm hoping that converting an existing driver of interest would not be a
massive undertaking.
I tend to agree with him.
As I'm having trouble envisioning what a real driver would look like,
converting an in-kernel driver ensures that the interface was sane instead
of exporting symbols that turn out to be unusable later. It'll also force
any objectors out of the closet sooner rather than later.
As it stands, I have no problems with the patches as such other than they
need a bit more spit and polish. The basic principal seems ok.
> Seems I gave a not so good description for this patch set so it caused
> a lot of misunderstanding, sorry about that.
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-17 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 5:30 Alexey Korolev
2009-09-14 16:54 ` Christoph Hellwig
2009-09-17 6:42 ` Alexey Korolev
2009-09-17 9:14 ` Mel Gorman [this message]
2009-09-21 5:16 ` Alexey Korolev
2009-09-21 9:04 ` Mel Gorman
2009-09-22 6:40 ` Alexey Korolev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090917091408.GB13002@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akorolev@infradead.org \
--cc=akorolex@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mm@mgebm.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox