Re: Isolated(anon) and Isolated(file)

[KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>]

> On Tue, 15 Sep 2009, KOSAKI Motohiro wrote:
> > From 7aa6fa2b76ff5d063b8bfa4a3af38c39b9396fd5 Mon Sep 17 00:00:00 2001
> > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Date: Tue, 15 Sep 2009 10:16:51 +0900
> > Subject: [PATCH] Kill Isolated field in /proc/meminfo
> > 
> > Hugh Dickins pointed out Isolated field dislpay 0kB at almost time.
> > It is only increased at heavy memory pressure case.
> > 
> > So, if the system haven't get memory pressure, this field isn't useful.
> > And now, we have two alternative way, /sys/device/system/node/node{n}/meminfo
> > and /prov/vmstat. Then, it can be removed.
> > 
> > Reported-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> 
> Acked-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
> 
> I should be overjoyed that you agree to hide the Isolateds from my sight:
> thank you.  But in fact I'm a little depressed, now you've reminded me of
> almost-the-same-but-annoyingly-different /sys/devices/unmemorable/meminfo.
> 
> Oh well, since I never see it (I'd need some nodes), I guess I don't
> even need to turn a blind eye to it; and it already contains other
> stuff I objected to in /proc/meminfo.
> 
> I still think your Isolateds make most sense in the OOM display;
> and yes, they are there in /proc/vmstat, that's good too.

Hmm..
You touch different another problem. /proc/vmstat don't have sufficient
capability. Recently average #-of-cpus and numa rapidly become common.
Then, many administrator decide to run two or more each unrelated workload
on one machine and they are separated by cpuset.

However, /proc/vmstat don't have per-numa nor per-cpuset capability. then,
We lost a way of getting vm statistics.

<btw>
Another several user want per-memcgroup statistics. another user want another.
Several month ago, Ingo proposed object based tracing framework and /proc/vmstat
replace with it. I like his idea. but flexibility statiscis decrease
system performnce a bit. My brain haven't got the answer.
</btw>


Anyway, we need to decide drop or not before merge the patch. unfortunately
current is merge window.
Then, I decide to drop /sys/devices/node/meminfo too at once. Perhaps I'll
resubmit the same patch after (Of cource, perhaps not), but We know field
adding is feature enhancement but field removing is regression.

Andrew, very sorry, could you please pick up following patch and it merge
my last patch? the patch description also be rewritten.


========================================================
From 094c314ba851171d8201f4446783341ea0d22141 Mon Sep 17 00:00:00 2001
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Date: Wed, 16 Sep 2009 09:22:44 +0900
Subject: [PATCH] Kill Isolated field in /proc/meminfo fix

Hugh Dickins pointed out Isolated field dislpay 0kB at almost time.
It is only increased at heavy memory pressure case.

So, if the system haven't get memory pressure, this field isn't useful.
And now, we have an alternative way, (i.e. /prov/vmstat).
Then, it can be removed.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 drivers/base/node.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index f50621b..1fe5536 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -73,8 +73,6 @@ static ssize_t node_read_meminfo(struct sys_device * dev,
 		       "Node %d Active(file):   %8lu kB\n"
 		       "Node %d Inactive(file): %8lu kB\n"
 		       "Node %d Unevictable:    %8lu kB\n"
-		       "Node %d Isolated(anon): %8lu kB\n"
-		       "Node %d Isolated(file): %8lu kB\n"
 		       "Node %d Mlocked:        %8lu kB\n"
 #ifdef CONFIG_HIGHMEM
 		       "Node %d HighTotal:      %8lu kB\n"
@@ -108,8 +106,6 @@ static ssize_t node_read_meminfo(struct sys_device * dev,
 		       nid, K(node_page_state(nid, NR_ACTIVE_FILE)),
 		       nid, K(node_page_state(nid, NR_INACTIVE_FILE)),
 		       nid, K(node_page_state(nid, NR_UNEVICTABLE)),
-		       nid, K(node_page_state(nid, NR_ISOLATED_ANON)),
-		       nid, K(node_page_state(nid, NR_ISOLATED_FILE)),
 		       nid, K(node_page_state(nid, NR_MLOCK)),
 #ifdef CONFIG_HIGHMEM
 		       nid, K(i.totalhigh),
-- 
1.6.2.5



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>