Re: [RFC][PATCH 4/4][mmotm] memcg: coalescing charge

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Sat, 12 Sep 2009 13:58:25 +0900
Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp> wrote:

> > @@ -1320,6 +1423,9 @@ static int __mem_cgroup_try_charge(struc
> >  		if (!(gfp_mask & __GFP_WAIT))
> >  			goto nomem;
> >  
> > +		/* we don't make stocks if failed */
> > +		csize = PAGE_SIZE;
> > +
> >  		ret = mem_cgroup_hierarchical_reclaim(mem_over_limit, NULL,
> >  						gfp_mask, flags);
> >  		if (ret)
> It might be a nitpick though, isn't it better to move csize modification
> before checking __GFP_WAIT ?
> It might look like:
> 
> 	/* we don't make stocks if failed */
> 	if (csize > PAGE_SIZE) {
> 		csize = PAGE_SIZE;
> 		continue;
> 	}
> 
> 	if (!(gfp_mask & __GFP_WAIT))
> 		goto nomem;
> 
Hmm ok. thank you.
Because it's in merge-window, I don't push this series but will post
new version just for showing updates.

Thanks,
-Kame


> Thanks,
> Daisuke Nishimura.
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>