From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 1B3CD6B004D for ; Wed, 9 Sep 2009 20:22:14 -0400 (EDT) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n8A0MKWK024938 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Thu, 10 Sep 2009 09:22:20 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id D452645DE50 for ; Thu, 10 Sep 2009 09:22:19 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id AA0DE45DE4D for ; Thu, 10 Sep 2009 09:22:19 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 8DCA51DB8041 for ; Thu, 10 Sep 2009 09:22:19 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 2AEEB1DB803E for ; Thu, 10 Sep 2009 09:22:16 +0900 (JST) Date: Thu, 10 Sep 2009 09:20:17 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 0/4][mmotm] memcg: reduce lock contention v3 Message-Id: <20090910092017.3d550d5a.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090909203042.GA4473@balbir.in.ibm.com> References: <20090909173903.afc86d85.kamezawa.hiroyu@jp.fujitsu.com> <20090909203042.GA4473@balbir.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: balbir@linux.vnet.ibm.com Cc: "linux-mm@kvack.org" , "nishimura@mxp.nes.nec.co.jp" List-ID: On Thu, 10 Sep 2009 02:00:42 +0530 Balbir Singh wrote: > * KAMEZAWA Hiroyuki [2009-09-09 17:39:03]: > > > This patch series is for reducing memcg's lock contention on res_counter, v3. > > (sending today just for reporting current status in my stack.) > > > > It's reported that memcg's res_counter can cause heavy false sharing / lock > > conention and scalability is not good. This is for relaxing that. > > No terrible bugs are found, I'll maintain/update this until the end of next > > merge window. Tests on big-smp and new-good-idea are welcome. > > > > This patch is on to mmotm+Nishimura's fix + Hugh's get_user_pages() patch. > > But can be applied directly against mmotm, I think. > > > > numbers: > > > > I used 8cpu x86-64 box and run make -j 12 kernel. > > Before make, make clean and drop_caches. > > > > Kamezawa-San > > I was able to test on a 24 way using my parallel page fault test > program and here is what I see > thank you. > Performance counter stats for '/home/balbir/parallel_pagefault' (3 > runs): > > 7191673.834385 task-clock-msecs # 23.953 CPUs ( +- 0.001% ) > 427765 context-switches # 0.000 M/sec ( +- 0.106% ) > 234 CPU-migrations # 0.000 M/sec ( +- 20.851% ) > 87975343 page-faults # 0.012 M/sec ( +- 0.347% ) > 5962193345280 cycles # 829.041 M/sec ( +- 0.012% ) > 1009132401195 instructions # 0.169 IPC ( +- 0.059% ) > 10068652670 cache-references # 1.400 M/sec ( +- 2.581% ) > 2053688394 cache-misses # 0.286 M/sec ( +- 0.481% ) > > 300.238748326 seconds time elapsed ( +- 0.001% ) > > Without the patch I saw > > Performance counter stats for '/home/balbir/parallel_pagefault' (3 > runs): > > 7198364.596593 task-clock-msecs # 23.959 CPUs ( +- 0.004% ) > 425104 context-switches # 0.000 M/sec ( +- 0.244% ) > 157 CPU-migrations # 0.000 M/sec ( +- 13.291% ) > 28964117 page-faults # 0.004 M/sec ( +- 0.106% ) > 5786854402292 cycles # 803.912 M/sec ( +- 0.013% ) > 835828892399 instructions # 0.144 IPC ( +- 0.073% ) > 6240606753 cache-references # 0.867 M/sec ( +- 1.058% ) > 2068445332 cache-misses # 0.287 M/sec ( +- 1.844% ) > > 300.443366784 seconds time elapsed ( +- 0.005% ) > > > This does look like a very good improvement. > Seems good. BTW, why the number of page-faults after patch is 3 times bigger than one before patch ? The difference in the number of instructions meets it ? THanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org