From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 729E66B004D for ; Mon, 31 Aug 2009 19:30:09 -0400 (EDT) Received: by ewy12 with SMTP id 12so4861701ewy.24 for ; Mon, 31 Aug 2009 16:30:08 -0700 (PDT) Date: Tue, 1 Sep 2009 08:29:26 +0900 From: Minchan Kim Subject: Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value. Message-Id: <20090901082926.61872690.minchan.kim@barrios-desktop> In-Reply-To: <1251759241-15167-1-git-send-email-macli@brc.ubc.ca> References: <1251759241-15167-1-git-send-email-macli@brc.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Vincent Li Cc: linux-mm@kvack.org, KOSAKI Motohiro , Rik van Riel , Minchan Kim , Wu Fengguang , Andrew Morton List-ID: On Mon, 31 Aug 2009 15:54:01 -0700 Vincent Li wrote: > commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle > sc->isolate_pages() return value properly. Add similar proper return value check for > shrink_active_list() sc->isolate_pages(). > > Signed-off-by: Vincent Li Reviewed-by: Minchan Kim You should have write down your patch's effect clearly in changelog although it's easy. ;-) -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org