From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
akpm@linux-foundation.org, hpa@zytor.com,
gregory.haskins@gmail.com
Subject: Re: [PATCHv4 2/2] vhost_net: a kernel-level virtio server
Date: Thu, 27 Aug 2009 20:40:02 +0930 [thread overview]
Message-ID: <200908272040.02628.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090827104517.GB8545@redhat.com>
On Thu, 27 Aug 2009 08:15:18 pm Michael S. Tsirkin wrote:
> On Tue, Aug 25, 2009 at 09:40:40PM +0930, Rusty Russell wrote:
> > Also, see other fixes to the lguest launcher since then which might
> > be relevant to this code:
> > lguest: get more serious about wmb() in example Launcher code
>
> Heh, this just gets one step closer to a real wmb. I just used the
> correct code from linux, so I think nothing needs to be done in vhost.
> Apropos this change in lguest: why is a compiler barrier sufficient? The
> comment says devices are run in separate threads (presumably from
> guest?), if so don't you need to tell CPU that there's a barrier as
> well?
Yep, but x86 only :) The kernel uses a real insn if XMM/XMM2, but I don't
know if userspace needs that. I just use compiler barriers.
Thanks,
Rusty.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-27 11:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1250693417.git.mst@redhat.com>
2009-08-19 15:02 ` [PATCHv4 1/2] mm: export use_mm/unuse_mm to modules Michael S. Tsirkin
2009-08-19 15:03 ` [PATCHv4 2/2] vhost_net: a kernel-level virtio server Michael S. Tsirkin
2009-08-25 12:10 ` Rusty Russell
2009-08-25 13:16 ` Michael S. Tsirkin
2009-08-26 16:56 ` Michael S. Tsirkin
2009-08-27 9:59 ` Rusty Russell
2009-08-25 17:50 ` Michael S. Tsirkin
2009-08-26 13:40 ` Arnd Bergmann
2009-08-26 13:58 ` Michael S. Tsirkin
2009-08-27 10:10 ` Michael S. Tsirkin
2009-08-27 11:03 ` Rusty Russell
2009-08-27 10:45 ` Michael S. Tsirkin
2009-08-27 11:10 ` Rusty Russell [this message]
2009-08-27 11:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908272040.02628.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=gregory.haskins@gmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox