* [PATCH] mm/vmscan: remove page_queue_congested() comment
@ 2009-08-25 18:53 Vincent Li
2009-08-26 2:02 ` KOSAKI Motohiro
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Li @ 2009-08-25 18:53 UTC (permalink / raw)
To: linux-mm; +Cc: KOSAKI Motohiro, Andrew Morton, Peter Zijlstra, Vincent Li
Commit 084f71ae5c(kill page_queue_congested()) removed page_queue_congested().
Remove the page_queue_congested() comment in vmscan pageout() too.
Signed-off-by: Vincent Li <macli@brc.ubc.ca>
---
mm/vmscan.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 848689a..1219ceb 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -366,7 +366,6 @@ static pageout_t pageout(struct page *page, struct address_space *mapping,
* block, for some throttling. This happens by accident, because
* swap_backing_dev_info is bust: it doesn't reflect the
* congestion state of the swapdevs. Easy to fix, if needed.
- * See swapfile.c:page_queue_congested().
*/
if (!is_page_cache_freeable(page))
return PAGE_KEEP;
--
1.6.0.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/vmscan: remove page_queue_congested() comment
2009-08-25 18:53 [PATCH] mm/vmscan: remove page_queue_congested() comment Vincent Li
@ 2009-08-26 2:02 ` KOSAKI Motohiro
0 siblings, 0 replies; 2+ messages in thread
From: KOSAKI Motohiro @ 2009-08-26 2:02 UTC (permalink / raw)
To: Vincent Li; +Cc: kosaki.motohiro, linux-mm, Andrew Morton, Peter Zijlstra
> Commit 084f71ae5c(kill page_queue_congested()) removed page_queue_congested().
> Remove the page_queue_congested() comment in vmscan pageout() too.
>
> Signed-off-by: Vincent Li <macli@brc.ubc.ca>
> ---
> mm/vmscan.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 848689a..1219ceb 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -366,7 +366,6 @@ static pageout_t pageout(struct page *page, struct address_space *mapping,
> * block, for some throttling. This happens by accident, because
> * swap_backing_dev_info is bust: it doesn't reflect the
> * congestion state of the swapdevs. Easy to fix, if needed.
> - * See swapfile.c:page_queue_congested().
> */
> if (!is_page_cache_freeable(page))
> return PAGE_KEEP;
Thanks for carefully review and followup fixes.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-26 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-25 18:53 [PATCH] mm/vmscan: remove page_queue_congested() comment Vincent Li
2009-08-26 2:02 ` KOSAKI Motohiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox