From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Vincent Li <macli@brc.ubc.ca>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] mm/vmscan: remove page_queue_congested() comment
Date: Wed, 26 Aug 2009 11:02:38 +0900 (JST) [thread overview]
Message-ID: <20090826111156.9A23.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1251226422-17878-1-git-send-email-macli@brc.ubc.ca>
> Commit 084f71ae5c(kill page_queue_congested()) removed page_queue_congested().
> Remove the page_queue_congested() comment in vmscan pageout() too.
>
> Signed-off-by: Vincent Li <macli@brc.ubc.ca>
> ---
> mm/vmscan.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 848689a..1219ceb 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -366,7 +366,6 @@ static pageout_t pageout(struct page *page, struct address_space *mapping,
> * block, for some throttling. This happens by accident, because
> * swap_backing_dev_info is bust: it doesn't reflect the
> * congestion state of the swapdevs. Easy to fix, if needed.
> - * See swapfile.c:page_queue_congested().
> */
> if (!is_page_cache_freeable(page))
> return PAGE_KEEP;
Thanks for carefully review and followup fixes.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-08-26 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 18:53 Vincent Li
2009-08-26 2:02 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826111156.9A23.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=macli@brc.ubc.ca \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox