From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id A81426B004D for ; Tue, 18 Aug 2009 22:37:39 -0400 (EDT) Date: Wed, 19 Aug 2009 10:37:37 +0800 From: Wu Fengguang Subject: Re: [Patch] proc: drop write permission on 'timer_list' and 'slabinfo' Message-ID: <20090819023737.GA17710@localhost> References: <20090817094822.GA17838@elte.hu> <1250502847.5038.16.camel@penberg-laptop> <4A8986BB.80409@cs.helsinki.fi> <4A8A0B0D.6080400@redhat.com> <4A8A0B14.8040700@cn.fujitsu.com> <4A8A1B2E.20505@redhat.com> <20090818120032.GA22152@localhost> <4A8B652E.40905@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A8B652E.40905@redhat.com> Sender: owner-linux-mm@kvack.org To: Amerigo Wang Cc: Li Zefan , Christoph Lameter , Pekka Enberg , Ingo Molnar , "linux-kernel@vger.kernel.org" , Vegard Nossum , Eduard - Gabriel Munteanu , Thomas Gleixner , "linux-mm@kvack.org" , David Rientjes , Matt Mackall , Arjan van de Ven List-ID: On Wed, Aug 19, 2009 at 10:36:30AM +0800, Amerigo Wang wrote: > Wu Fengguang wrote: > > On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote: > > > > > >> - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations); > >> + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations); > >> > > > > Style nitpick. The spaces were packed to fit into 80-col I guess. > > > > > > Yeah, I noticed this too, the reason I didn't fix this is that I don't > want to mix coding style fix with this one. We can fix it in another > patch, if you want. :) Why not? This don't hurt readability of the patch, hehe. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org