From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] replace various uses of num_physpages by totalram_pages
Date: Tue, 18 Aug 2009 17:38:15 +0200 [thread overview]
Message-ID: <20090818153815.GA11913@elte.hu> (raw)
In-Reply-To: <4A8AE6280200007800010539@vpn.id2.novell.com>
* Jan Beulich <JBeulich@novell.com> wrote:
> Sizing of memory allocations shouldn't depend on the number of
> physical pages found in a system, as that generally includes
> (perhaps a huge amount of) non-RAM pages. The amount of what
> actually is usable as storage should instead be used as a basis
> here.
>
> Some of the calculations (i.e. those not intending to use high
> memory) should likely even use (totalram_pages -
> totalhigh_pages).
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>
> ---
> arch/x86/kernel/microcode_core.c | 4 ++--
Acked-by: Ingo Molnar <mingo@elte.hu>
Just curious: how did you find this bug? Did you find this by
experiencing problems on a system with a lot of declared non-RAM
memory?
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-18 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 15:34 Jan Beulich
2009-08-18 15:38 ` Ingo Molnar [this message]
2009-08-18 15:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818153815.GA11913@elte.hu \
--to=mingo@elte.hu \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox