From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 096FD6B004D for ; Tue, 18 Aug 2009 08:43:15 -0400 (EDT) Date: Tue, 18 Aug 2009 20:00:32 +0800 From: Wu Fengguang Subject: Re: [Patch] proc: drop write permission on 'timer_list' and 'slabinfo' Message-ID: <20090818120032.GA22152@localhost> References: <20090817094525.6355.88682.sendpatchset@localhost.localdomain> <20090817094822.GA17838@elte.hu> <1250502847.5038.16.camel@penberg-laptop> <4A8986BB.80409@cs.helsinki.fi> <4A8A0B0D.6080400@redhat.com> <4A8A0B14.8040700@cn.fujitsu.com> <4A8A1B2E.20505@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A8A1B2E.20505@redhat.com> Sender: owner-linux-mm@kvack.org To: Amerigo Wang Cc: Li Zefan , Christoph Lameter , Pekka Enberg , Ingo Molnar , linux-kernel@vger.kernel.org, Vegard Nossum , Eduard - Gabriel Munteanu , Thomas Gleixner , linux-mm@kvack.org, David Rientjes , Matt Mackall , Arjan van de Ven List-ID: On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote: > - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations); > + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations); Style nitpick. The spaces were packed to fit into 80-col I guess. ERROR: space required after that ',' (ctx:VxV) #10: FILE: mm/slub.c:4729: + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations); ^ ERROR: space required after that ',' (ctx:VxV) #10: FILE: mm/slub.c:4729: + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations); ^ ERROR: space required after that ',' (ctx:VxO) #10: FILE: mm/slub.c:4729: + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations); ^ ERROR: space required before that '&' (ctx:OxV) #10: FILE: mm/slub.c:4729: + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations); ^ Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org