From: Wu Fengguang <fengguang.wu@intel.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Vegard Nossum <vegard.nossum@gmail.com>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Thomas Gleixner <tglx@linutronix.de>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Matt Mackall <mpm@selenic.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [Patch] proc: drop write permission on 'timer_list' and 'slabinfo'
Date: Tue, 18 Aug 2009 20:00:32 +0800 [thread overview]
Message-ID: <20090818120032.GA22152@localhost> (raw)
In-Reply-To: <4A8A1B2E.20505@redhat.com>
On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote:
> - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
Style nitpick. The spaces were packed to fit into 80-col I guess.
ERROR: space required after that ',' (ctx:VxV)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^
ERROR: space required after that ',' (ctx:VxV)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^
ERROR: space required after that ',' (ctx:VxO)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^
ERROR: space required before that '&' (ctx:OxV)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-18 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 9:43 Amerigo Wang
2009-08-17 9:48 ` Ingo Molnar
2009-08-17 9:54 ` Pekka Enberg
2009-08-17 16:29 ` Christoph Lameter
2009-08-17 16:35 ` Pekka Enberg
2009-08-17 16:41 ` Christoph Lameter
2009-08-18 1:59 ` Amerigo Wang
2009-08-18 1:59 ` Li Zefan
2009-08-18 3:08 ` Amerigo Wang
2009-08-18 12:00 ` Wu Fengguang [this message]
2009-08-19 2:36 ` Amerigo Wang
2009-08-19 2:37 ` Wu Fengguang
2009-08-19 10:39 ` Amerigo Wang
2009-08-19 18:47 ` Pekka Enberg
2009-08-20 10:34 ` Amerigo Wang
2009-08-18 16:12 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818120032.GA22152@localhost \
--to=fengguang.wu@intel.com \
--cc=amwang@redhat.com \
--cc=arjan@linux.intel.com \
--cc=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox