From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Nicolas Pitre <nico@marvell.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
rt-users <linux-rt-users@vger.kernel.org>,
MinChan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Li Zefan <lizf@cn.fujitsu.com>,
Jens Axboe <jens.axboe@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -rt] Fix kmap_high_get()
Date: Fri, 14 Aug 2009 22:13:11 +0200 [thread overview]
Message-ID: <20090814201311.GA453@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0908141152290.10633@xanadu.home>
Hello,
On Fri, Aug 14, 2009 at 11:58:59AM -0400, Nicolas Pitre wrote:
> On Fri, 14 Aug 2009, Peter Zijlstra wrote:
>
> > As to the patch, its not quite right.
... on irc Peter and me agreed it's not that wrong :-) Anyhow, I merged
the two patches to get the benefits from both. See below.
> > From what I understand kmap_high_get() is used to pin a page's kmap iff
> > it has one, whereas the result of your patch seems to be that it'll
> > actually create one if its not found.
>
> I don't have enough context to review this patch, but your understanding
> of the kmap_high_get() purpose is right.
The patch with all it's dependencies based on -rc6 is available on
git://git.pengutronix.de/git/ukl/linux-2.6.git kmap-testing
Niko: Your review would be very welcome because neither Peter nor me
have a machine with highmem.
Best regards
Uwe
prev parent reply other threads:[~2009-08-14 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090807203939.GA19374@pengutronix.de>
2009-08-09 9:36 ` [PATCH RT 7/6] include linux/interrupt.h in mm/bounce.c Uwe Kleine-König
[not found] ` <1249810600-21946-2-git-send-email-u.kleine-koenig@pengutronix.de>
2009-08-09 9:36 ` [PATCH RT 9/6] [RFH] Build failure on 2.6.31-rc4-rt1 in mm/highmem.c Uwe Kleine-König
2009-08-13 21:34 ` [PATCH] [RFC, RT] fix kmap_high_get Uwe Kleine-König
2009-08-14 14:02 ` [PATCH -rt] Fix kmap_high_get() Peter Zijlstra
2009-08-14 15:58 ` Nicolas Pitre
2009-08-14 20:13 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090814201311.GA453@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=minchan.kim@gmail.com \
--cc=mingo@elte.hu \
--cc=nico@marvell.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox