From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [patch 3/5] mm: return boolean from page_is_file_cache()
Date: Fri, 14 Aug 2009 15:56:50 +0900 (JST) [thread overview]
Message-ID: <20090814144443.CBE1.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1250065929-17392-3-git-send-email-hannes@cmpxchg.org>
> page_is_file_cache() has been used for both boolean checks and LRU
> arithmetic, which was always a bit weird.
>
> Now that page_lru_base_type() exists for LRU arithmetic, make
> page_is_file_cache() a real predicate function and adjust the
> boolean-using callsites to drop those pesky double negations.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Looks good to me.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-14 6:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 8:32 [patch 1/5] mm: drop unneeded double negations Johannes Weiner
2009-08-12 8:32 ` [patch 2/5] mm: introduce page_lru_base_type() Johannes Weiner
2009-08-14 6:56 ` KOSAKI Motohiro
2009-08-12 8:32 ` [patch 3/5] mm: return boolean from page_is_file_cache() Johannes Weiner
2009-08-14 6:56 ` KOSAKI Motohiro [this message]
2009-08-12 8:32 ` [patch 4/5] mm: return boolean from page_has_private() Johannes Weiner
2009-08-12 13:57 ` Christoph Lameter
2009-08-14 6:56 ` KOSAKI Motohiro
2009-08-12 8:32 ` [patch 5/5] mm: document is_page_cache_freeable() Johannes Weiner
2009-08-12 13:58 ` Christoph Lameter
2009-08-14 6:56 ` KOSAKI Motohiro
2009-08-14 6:56 ` [patch 1/5] mm: drop unneeded double negations KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090814144443.CBE1.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox