Re: [PATCH 3/3] Add MAP_HUGETLB example to vm/hugetlbpage.txt V2

[Eric B Munson <ebmunson@us.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

On Thu, 13 Aug 2009, Randy Dunlap wrote:

> David Rientjes wrote:
> > On Thu, 13 Aug 2009, Eric B Munson wrote:
> > 
> >> This patch adds an example of how to use the MAP_HUGETLB flag to
> >> the vm documentation.
> >>
> >> Signed-off-by: Eric B Munson <ebmunson@us.ibm.com>
> >> ---
> >> Changes from V1:
> >>  Rebase to newest linux-2.6 tree
> >>  Change MAP_LARGEPAGE to MAP_HUGETLB to match flag name in huge page shm
> >>
> >>  Documentation/vm/hugetlbpage.txt |   80 ++++++++++++++++++++++++++++++++++++++
> >>  1 files changed, 80 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/Documentation/vm/hugetlbpage.txt b/Documentation/vm/hugetlbpage.txt
> >> index ea8714f..d30fa1a 100644
> >> --- a/Documentation/vm/hugetlbpage.txt
> >> +++ b/Documentation/vm/hugetlbpage.txt
> >> @@ -337,3 +337,83 @@ int main(void)
> >>  
> >>  	return 0;
> >>  }
> >> +
> >> +*******************************************************************
> >> +
> >> +/*
> >> + * Example of using hugepage memory in a user application using the mmap
> >> + * system call with MAP_LARGEPAGE flag.  Before running this program make
> > 
> > s/MAP_LARGEPAGE/MAP_HUGETLB/
> 
> I'm (slowly) making source code examples in Documentation/ buildable,
> as this one should be, please.
> 
> I.e., put it in a separate source file (hugetlbpage.txt can refer to the
> source file if you want it to) and add a Makefile similar to other
> Makefiles in the Documentation/ tree.
> 
> ~Randy
> 

I will make these changes for V3, thanks for the reviews.

-- 
Eric B Munson
IBM Linux Technology Center
ebmunson@us.ibm.com


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]