From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id D40C76B004D for ; Fri, 7 Aug 2009 03:53:30 -0400 (EDT) Date: Fri, 7 Aug 2009 09:53:17 +0200 From: Ingo Molnar Subject: Re: [PATCH 3/6] tracing, page-allocator: Add trace event for page traffic related to the buddy lists Message-ID: <20090807075317.GC20292@elte.hu> References: <1249574827-18745-1-git-send-email-mel@csn.ul.ie> <1249574827-18745-4-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1249574827-18745-4-git-send-email-mel@csn.ul.ie> Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Larry Woodman , Andrew Morton , riel@redhat.com, Peter Zijlstra , LKML , linux-mm@kvack.org List-ID: * Mel Gorman wrote: > +TRACE_EVENT(mm_page_pcpu_drain, > + > + TP_PROTO(struct page *page, int order, int migratetype), > + > + TP_ARGS(page, order, migratetype), > + > + TP_STRUCT__entry( > + __field( struct page *, page ) > + __field( int, order ) > + __field( int, migratetype ) > + ), > + > + TP_fast_assign( > + __entry->page = page; > + __entry->order = order; > + __entry->migratetype = migratetype; > + ), > + > + TP_printk("page=%p pfn=%lu order=%d cpu=%d migratetype=%d", > + __entry->page, > + page_to_pfn(__entry->page), > + __entry->order, > + smp_processor_id(), > + __entry->migratetype) > + trace_mm_page_alloc_zone_locked(page, order, migratetype, order == 0); This can be optimized further by omitting the migratetype field and adding something like this: TP_printk("page=%p pfn=%lu order=%d cpu=%d migratetype=%d", __entry->page, page_to_pfn(__entry->page), __entry->order, smp_processor_id(), __entry->order == 0); The advantage is 4 bytes less in the record and a shorter tracepoint fast-path - while still having the same output. Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org