Re: [PATCH] mv clear node_load[] to __build_all_zonelists()

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Thu, 6 Aug 2009 18:44:40 +0800
Bo Liu <bo-liu@hotmail.com> wrote:

> 
>  If node_load[] is cleared everytime build_zonelists() is called,node_load[]
>  will have no help to find the next node that should appear in the given node's
>  fallback list.
>  Signed-off-by: Bob Liu 

nice catch. (my old bug...sorry

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

BTW, do you have special reasons to hide your mail address in commit log ?

I added proper CC: list.
Hmm, I think it's necessary to do total review/rewrite this function again..


> ---
>  mm/page_alloc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>  
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index d052abb..72f7345 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2544,7 +2544,6 @@ static void build_zonelists(pg_data_t *pgdat)
>  	prev_node = local_node;
>  	nodes_clear(used_mask);
>  
> -	memset(node_load, 0, sizeof(node_load));
>  	memset(node_order, 0, sizeof(node_order));
>  	j = 0;
>  
> @@ -2653,6 +2652,7 @@ static int __build_all_zonelists(void *dummy)
>  {
>  	int nid;
>  
> +	memset(node_load, 0, sizeof(node_load));
>  	for_each_online_node(nid) {
>  		pg_data_t *pgdat = NODE_DATA(nid);
> 
> 
> 
> 
> _________________________________________________________________
> Drag na?? dropa??Get easy photo sharing with Windows Livea?c Photos.
> 
> http://www.microsoft.com/windows/windowslive/products/photos.aspx

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>