linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Nick Piggin <npiggin@suse.de>,
	linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slqb: add declaration for kmem_cache_init_late()
Date: Wed, 5 Aug 2009 21:17:27 -0700	[thread overview]
Message-ID: <20090805211727.cd4ccedd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090806022704.GA17337@localhost>

On Thu, 6 Aug 2009 10:27:04 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:

> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
>  include/linux/slqb_def.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-mm.orig/include/linux/slqb_def.h	2009-07-20 20:10:20.000000000 +0800
> +++ linux-mm/include/linux/slqb_def.h	2009-08-06 10:17:05.000000000 +0800
> @@ -298,4 +298,6 @@ static __always_inline void *kmalloc_nod
>  }
>  #endif
>  
> +void __init kmem_cache_init_late(void);
> +
>  #endif /* _LINUX_SLQB_DEF_H */

spose so.

As all sl[a-zA-Z_]b.c must implement this, why not put the declaration
into slab.h?

That would require uninlining the slob one, but it's tiny and __init.

That's one for Pekka to worry about ;)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-08-06  4:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06  2:27 Wu Fengguang
2009-08-06  4:17 ` Andrew Morton [this message]
2009-08-06  5:31   ` [PATCH] slab: remove duplicate kmem_cache_init_late() declarations Wu Fengguang
2009-08-06  9:02     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090805211727.cd4ccedd.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox