linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: fengguang.wu@intel.com, akpm@linux-foundation.org,
	npiggin@suse.de, linux-kernel@vger.kernel.org,
	linux-mm@kvack.orgfengguang.wu@intel.com,
	hidehiro.kawai.ez@hitachi.com
Subject: [PATCH] [12/19] HWPOISON: Add invalidate_inode_page
Date: Wed,  5 Aug 2009 11:36:39 +0200 (CEST)	[thread overview]
Message-ID: <20090805093639.D5FBEB15D8@basil.firstfloor.org> (raw)
In-Reply-To: <200908051136.682859934@firstfloor.org>


From: Wu Fengguang <fengguang.wu@intel.com>

Add a simple way to invalidate a single page
This is just a refactoring of the truncate.c code.
Originally from Fengguang, modified by Andi Kleen.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 include/linux/mm.h |    2 ++
 mm/truncate.c      |   26 ++++++++++++++++++++------
 2 files changed, 22 insertions(+), 6 deletions(-)

Index: linux/include/linux/mm.h
===================================================================
--- linux.orig/include/linux/mm.h
+++ linux/include/linux/mm.h
@@ -811,6 +811,8 @@ extern int vmtruncate_range(struct inode
 
 int truncate_inode_page(struct address_space *mapping, struct page *page);
 
+int invalidate_inode_page(struct page *page);
+
 #ifdef CONFIG_MMU
 extern int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct *vma,
 			unsigned long address, unsigned int flags);
Index: linux/mm/truncate.c
===================================================================
--- linux.orig/mm/truncate.c
+++ linux/mm/truncate.c
@@ -146,6 +146,24 @@ int truncate_inode_page(struct address_s
 	return truncate_complete_page(mapping, page);
 }
 
+/*
+ * Safely invalidate one page from its pagecache mapping.
+ * It only drops clean, unused pages. The page must be locked.
+ *
+ * Returns 1 if the page is successfully invalidated, otherwise 0.
+ */
+int invalidate_inode_page(struct page *page)
+{
+	struct address_space *mapping = page_mapping(page);
+	if (!mapping)
+		return 0;
+	if (PageDirty(page) || PageWriteback(page))
+		return 0;
+	if (page_mapped(page))
+		return 0;
+	return invalidate_complete_page(mapping, page);
+}
+
 /**
  * truncate_inode_pages - truncate range of pages specified by start & end byte offsets
  * @mapping: mapping to truncate
@@ -312,12 +330,8 @@ unsigned long invalidate_mapping_pages(s
 			if (lock_failed)
 				continue;
 
-			if (PageDirty(page) || PageWriteback(page))
-				goto unlock;
-			if (page_mapped(page))
-				goto unlock;
-			ret += invalidate_complete_page(mapping, page);
-unlock:
+			ret += invalidate_inode_page(page);
+
 			unlock_page(page);
 			if (next > end)
 				break;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-08-05  9:36 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05  9:36 [PATCH] [0/19] HWPOISON: Intro Andi Kleen
2009-08-05  9:36 ` [PATCH] [1/19] HWPOISON: Add page flag for poisoned pages Andi Kleen
2009-08-05  9:36 ` [PATCH] [2/19] HWPOISON: Export some rmap vma locking to outside world Andi Kleen
2009-08-05  9:36 ` [PATCH] [3/19] HWPOISON: Add support for poison swap entries v2 Andi Kleen
2009-08-05  9:36 ` [PATCH] [4/19] HWPOISON: Add new SIGBUS error codes for hardware poison signals Andi Kleen
2009-08-05  9:36 ` [PATCH] [5/19] HWPOISON: Add basic support for poisoned pages in fault handler v3 Andi Kleen
2009-08-05  9:36 ` [PATCH] [6/19] HWPOISON: Add various poison checks in mm/memory.c v2 Andi Kleen
2009-08-05  9:36 ` [PATCH] [7/19] HWPOISON: x86: Add VM_FAULT_HWPOISON handling to x86 page fault handler v2 Andi Kleen
2009-08-05  9:36 ` [PATCH] [8/19] HWPOISON: Use bitmask/action code for try_to_unmap behaviour Andi Kleen
2009-08-05  9:36 ` [PATCH] [9/19] HWPOISON: Handle hardware poisoned pages in try_to_unmap Andi Kleen
2009-08-05  9:36 ` [PATCH] [10/19] HWPOISON: check and isolate corrupted free pages v2 Andi Kleen
2009-08-05  9:36 ` [PATCH] [11/19] HWPOISON: Refactor truncate to allow direct truncating of page v2 Andi Kleen
2009-08-05 10:20   ` Nick Piggin
2009-08-05 12:37     ` Wu Fengguang
2009-08-05 13:46     ` Andi Kleen
2009-08-05 14:01       ` Nick Piggin
2009-08-05 14:10         ` Andi Kleen
2009-08-05 14:16           ` Nick Piggin
2009-08-05 14:41             ` Andi Kleen
2009-08-05 14:44               ` Nick Piggin
2009-08-05 15:00               ` Matthew Wilcox
2009-08-06 11:48             ` Martin Schwidefsky
2009-08-06 12:04               ` Andi Kleen
2009-08-05 15:12         ` Wu Fengguang
2009-08-05  9:36 ` Andi Kleen [this message]
2009-08-05  9:36 ` [PATCH] [13/19] HWPOISON: Define a new error_remove_page address space op for async truncation Andi Kleen
2009-08-05  9:36 ` [PATCH] [14/19] HWPOISON: Add PR_MCE_KILL prctl to control early kill behaviour per process Andi Kleen
2009-08-05  9:36 ` [PATCH] [15/19] HWPOISON: The high level memory error handler in the VM v7 Andi Kleen
2009-08-05  9:36 ` [PATCH] [16/19] HWPOISON: Enable .remove_error_page for migration aware file systems Andi Kleen
2009-08-05 11:12   ` Christoph Hellwig
2009-08-05 11:52     ` Wu Fengguang
2009-08-05 13:50     ` Andi Kleen
2009-08-10  6:36   ` Hidehiro Kawai
2009-08-10  7:07     ` Wu Fengguang
2009-08-11  3:48       ` Hidehiro Kawai
2009-08-11  6:59         ` Andi Kleen
2009-08-11 12:38         ` Wu Fengguang
2009-08-10  7:44     ` Andi Kleen
2009-08-11  3:50       ` Hidehiro Kawai
2009-08-11  7:17         ` Andi Kleen
2009-08-12  2:49           ` Hidehiro Kawai
2009-08-12  7:46             ` Andi Kleen
2009-08-12  9:52               ` Hidehiro Kawai
2009-08-12 10:16                 ` Andi Kleen
2009-08-12  8:05           ` Nick Piggin
2009-08-12  8:23             ` Andi Kleen
2009-08-12  8:46               ` Nick Piggin
2009-08-12  8:57                 ` Andi Kleen
2009-08-12  9:05                   ` Nick Piggin
2009-08-12  9:39                     ` Wu Fengguang
2009-08-05  9:36 ` [PATCH] [17/19] HWPOISON: Enable error_remove_page for NFS Andi Kleen
2009-08-05  9:36 ` [PATCH] [18/19] HWPOISON: Add madvise() based injector for hardware poisoned pages v3 Andi Kleen
2009-08-05  9:36 ` [PATCH] [19/19] HWPOISON: Add simple debugfs interface to inject hwpoison on arbitary PFNs Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090805093639.D5FBEB15D8@basil.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.orgfengguang.wu \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox