From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 5970F6B004D for ; Mon, 20 Jul 2009 12:22:26 -0400 (EDT) Date: Tue, 21 Jul 2009 01:22:25 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 3/3] add isolate pages vmstat In-Reply-To: References: <20090720143838.7481.A69D9226@jp.fujitsu.com> Message-Id: <20090721012054.AF7B.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Andrew Morton , Wu Fengguang , Rik van Riel , Minchan Kim List-ID: > On Mon, 20 Jul 2009, KOSAKI Motohiro wrote: > > > > On Fri, 17 Jul 2009, KOSAKI Motohiro wrote: > > > > > > > > Why do a separate pass over all the migrates pages? Can you add the > > > > > _inc_xx somewhere after the page was isolated from the lru by calling > > > > > try_to_unmap()? > > > > > > > > calling try_to_unmap()? the pages are isolated before calling migrate_pages(). > > > > migrate_pages() have multiple caller. then I put this __inc_xx into top of > > > > migrate_pages(). > > > > > > Then put the inc_xxx's where the pages are isolated. > > > > Is there any benefit? Why do we need sprinkle __inc_xx to many place? > > Its only needed in one place where the pages are isolated. Umm.. I haven't understand this benefit. but I guess I can do that. I'll think it later deeply. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org