From: Christoph Hellwig <hch@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: xfs mr_lock vs mmap_sem lock inversion?
Date: Fri, 17 Jul 2009 11:09:22 -0400 [thread overview]
Message-ID: <20090717150922.GA434@infradead.org> (raw)
In-Reply-To: <1247580955.7500.97.camel@twins>
It's a problem in the VM code, which we already discussed a while
ago. The problem is that the VMA manipultation code calls fput
under the mmap_sem, while we can take mmap_sem ue to a page fault
from inside generic_file_aio_read/write. So any filesystem
that nees the same lock held over read/write also in release is
crewed.
Now on the positive side I think we can actually get rid of taking
the iolock in ->release in XFS, but I'm sure other filesystems
might continue hitting similar issues.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
parent reply other threads:[~2009-07-17 15:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1247580955.7500.97.camel@twins>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717150922.GA434@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox