From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 87FD46B004F for ; Thu, 16 Jul 2009 20:17:40 -0400 (EDT) Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n6H0Hipv026032 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Fri, 17 Jul 2009 09:17:44 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id A718745DE55 for ; Fri, 17 Jul 2009 09:17:44 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 80D6445DE52 for ; Fri, 17 Jul 2009 09:17:44 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 5765BE08002 for ; Fri, 17 Jul 2009 09:17:44 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id F1E3D1DB8038 for ; Fri, 17 Jul 2009 09:17:43 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2 In-Reply-To: <20090716160139.GB1883@cmpxchg.org> References: <20090716160139.GB1883@cmpxchg.org> Message-Id: <20090717091653.A909.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Fri, 17 Jul 2009 09:17:43 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Johannes Weiner Cc: kosaki.motohiro@jp.fujitsu.com, Christoph Lameter , Mel Gorman , Andrew Morton , Maxim Levitsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lee Schermerhorn , Pekka Enberg , Jiri Slaby List-ID: > On Thu, Jul 16, 2009 at 09:54:49AM -0400, Christoph Lameter wrote: > > On Thu, 16 Jul 2009, KOSAKI Motohiro wrote: > > > > > I like this patch. but can you please separate two following patches? > > > - introduce __TESTCLEARFLAG() > > > - non-atomic test-clear of PG_mlocked on free > > > > That would mean introducing the macro without any use case? It is fine the > > way it is I think. > > Yeah, it's borderline. In any case, I have the split version here as > well. Andrew, you choose :) > > > Reviewed-by: Christoph Lameter > > Thanks, OK, I can agree with Christoph. you don't need change the patch. Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org