From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
Christoph Lameter <cl@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2
Date: Fri, 17 Jul 2009 09:17:43 +0900 (JST) [thread overview]
Message-ID: <20090717091653.A909.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090716160139.GB1883@cmpxchg.org>
> On Thu, Jul 16, 2009 at 09:54:49AM -0400, Christoph Lameter wrote:
> > On Thu, 16 Jul 2009, KOSAKI Motohiro wrote:
> >
> > > I like this patch. but can you please separate two following patches?
> > > - introduce __TESTCLEARFLAG()
> > > - non-atomic test-clear of PG_mlocked on free
> >
> > That would mean introducing the macro without any use case? It is fine the
> > way it is I think.
>
> Yeah, it's borderline. In any case, I have the split version here as
> well. Andrew, you choose :)
>
> > Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
>
> Thanks,
OK, I can agree with Christoph. you don't need change the patch.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-17 0:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 12:58 Mel Gorman
2009-07-15 14:31 ` Christoph Lameter
2009-07-15 22:04 ` Johannes Weiner
2009-07-16 7:37 ` KOSAKI Motohiro
2009-07-16 13:54 ` Christoph Lameter
2009-07-16 16:01 ` Johannes Weiner
2009-07-17 0:17 ` KOSAKI Motohiro [this message]
2009-07-22 23:06 ` Andrew Morton
2009-07-23 10:29 ` Mel Gorman
2009-07-23 17:23 ` Andrew Morton
2009-07-24 10:36 ` Mel Gorman
2009-07-24 11:31 ` Christoph Lameter
2009-07-24 12:00 ` Johannes Weiner
2009-07-24 12:59 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717091653.A909.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maximlevitsky@gmail.com \
--cc=mel@csn.ul.ie \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox