From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 3/5] Kill unnecessary prefetch
Date: Thu, 16 Jul 2009 17:39:19 +0900 (JST) [thread overview]
Message-ID: <20090716173848.9D51.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090716173449.9D4B.A69D9226@jp.fujitsu.com>
Subject: Kill unnecessary prefetch
The pages in the list passed move_active_pages_to_lru() are
already touched by shrink_active_list(). IOW the prefetch in
move_active_pages_to_lru() don't populate any cache. it's pointless.
This patch remove it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/vmscan.c | 1 -
1 file changed, 1 deletion(-)
Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1225,7 +1225,6 @@ static void move_active_pages_to_lru(str
while (!list_empty(list)) {
page = lru_to_page(list);
- prefetchw_prev_lru_page(page, list, flags);
VM_BUG_ON(PageLRU(page));
SetPageLRU(page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-16 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 8:37 [PATCH 1/5] move ClearPageActive from move_active_pages() to shrink_active_list() KOSAKI Motohiro
2009-07-16 8:38 ` [PATCH 2/5] Kill unnecessary page flag test KOSAKI Motohiro
2009-07-16 8:39 ` KOSAKI Motohiro [this message]
2009-07-16 8:40 ` [PATCH 4/5] Use add_page_to_lru_list() helper function KOSAKI Motohiro
2009-07-17 12:18 ` Peter Zijlstra
2009-07-20 5:37 ` KOSAKI Motohiro
2009-07-20 7:28 ` Peter Zijlstra
2009-07-20 14:30 ` KOSAKI Motohiro
2009-07-16 8:40 ` [PATCH 5/5] move PGDEACTIVATE modification to shrink_active_list() KOSAKI Motohiro
2009-07-16 17:14 ` [PATCH 1/5] move ClearPageActive from move_active_pages() " Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716173848.9D51.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox